From: Piotr Kubik <piotr@kubik.pl>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Tamizh Chelvam Raja <tamizh.raja@oss.qualcomm.com>,
Muna Sinada <muna.sinada@oss.qualcomm.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Piotr Kubik <piotr@kubik.pl>,
stable@vger.kernel.org
Subject: [PATCH wireless 1/2] wifi: mac80211: change the links of an AP_VLAN station through its AP
Date: Tue, 20 Oct 2026 14:44:45 +0200 [thread overview]
Message-ID: <20261020124446.188739-2-piotr@kubik.pl> (raw)
In-Reply-To: <20261020124446.188739-1-piotr@kubik.pl>
A 4-address station of an AP MLD moves to an AP_VLAN interface, so its
sta->sdata is the AP_VLAN. The AP_VLAN is never added to the driver,
so check_sdata_in_driver() in drv_change_sta_links() warns and returns
-EIO for every link change of such a station. Adding a link fails, and
removing a link leaves it in the driver, because
ieee80211_sta_remove_link() ignores the error.
Map the AP_VLAN to its AP first, as drv_sta_state() does.
Fixes: 469d5d5a3b7a ("wifi: mac80211: synchronize valid links for WDS AP_VLAN interfaces")
Cc: stable@vger.kernel.org
Signed-off-by: Piotr Kubik <piotr@kubik.pl>
---
net/mac80211/driver-ops.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/mac80211/driver-ops.c b/net/mac80211/driver-ops.c
--- a/net/mac80211/driver-ops.c
+++ b/net/mac80211/driver-ops.c
@@ -593,6 +593,7 @@ int drv_change_sta_links(struct ieee8021
might_sleep();
lockdep_assert_wiphy(local->hw.wiphy);
+ sdata = get_bss_sdata(sdata);
if (!check_sdata_in_driver(sdata))
return -EIO;
next prev parent reply other threads:[~2026-10-20 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 12:44 [PATCH wireless 0/2] wifi: mac80211: fix link changes of 4-address MLD stations Piotr Kubik
2026-10-20 12:44 ` Piotr Kubik [this message]
2026-10-20 12:44 ` [PATCH wireless 2/2] wifi: mac80211: set the link addresses of a 4-address AP_VLAN before its links Piotr Kubik
2026-10-21 4:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020124446.188739-2-piotr@kubik.pl \
--to=piotr@kubik.pl \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=muna.sinada@oss.qualcomm.com \
--cc=stable@vger.kernel.org \
--cc=tamizh.raja@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox