Re: [PATCH rtw-next v7 3/3] wifi: rtw88: time the countdown downloads from the TBTT

[Mehmet Fide <mehmet.fide@gmail.com>]

Hi Ping-Ke,

On 2026-10-21, Ping-Ke Shih wrote:
> +/* the beaconing interface is always on port 0 */
>
> Move into function? Or just mention this in commit message.

The commit message says it already, so v8 drops the comment.

> How about setting a retry limit? Consider if hardware goes wrong
> suddenly returning random number, I'm afraid it becomes infinite
> loop. As my thought, at most it needs one time retry.

Agreed. v8 reads the high word once more and, if it changed, the low
word again; no loop.

> an empty line

Will do, all three.

> The csa_tbtt is just read from register and adjusted to what you want,
> but in rtw_fw_csa_queue() it reads again and adjust. Can you reduce it?
> How about adding an argument to tell rtw_fw_csa_queue() that this is first
> time to initialize csa_tbtt (like the restart case)?

Yes. In v8 rtw_fw_csa_queue() takes a start argument and reads the TSF
once: on start it takes the next TBTT, or the one just passed within
the margin, and the countdown work adds an interval as before.

Regards,
Mehmet