From: Eduard Zateev <hackerowskiy@gmail.com>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+c38f93f387ac25eabf68@syzkaller.appspotmail.com
Subject: [PATCH] wifi: mac80211: use owner vif for AP VLAN station TXQs
Date: Mon, 26 Oct 2026 19:54:14 +1000 [thread overview]
Message-ID: <20261026095414.149334-1-hackerowskiy@gmail.com> (raw)
AP VLAN interfaces are not added to the driver, so their station TXQs
must wake the queue through the owning AP interface. Keep the AP VLAN
interface in skb control data for key selection, but associate its
station TXQ with the driver-facing AP vif.
This avoids calling drv_wake_tx_queue() with an AP VLAN vif that has no
IEEE80211_SDATA_IN_DRIVER flag.
Fixes: e937b8da5a59 ("mac80211: Add TXQ scheduling API")
Reported-by: syzbot+c38f93f387ac25eabf68@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=c38f93f387ac25eabf68
Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
---
net/mac80211/tx.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index e9b6a0415..7446c8d9d 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1571,6 +1571,13 @@ void ieee80211_txq_init(struct ieee80211_sub_if_data *sdata,
INIT_LIST_HEAD(&txqi->schedule_order);
txqi->txq.vif = &sdata->vif;
+ if (sta && sdata->vif.type == NL80211_IFTYPE_AP_VLAN) {
+ struct ieee80211_sub_if_data *ap;
+
+ ap = container_of(sdata->bss,
+ struct ieee80211_sub_if_data, u.ap);
+ txqi->txq.vif = &ap->vif;
+ }
if (!sta) {
txqi->txq.tid = tid;
--
2.56.0
reply other threads:[~2026-10-26 9:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026095414.149334-1-hackerowskiy@gmail.com \
--to=hackerowskiy@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=syzbot+c38f93f387ac25eabf68@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox