Linux wireless drivers development
 help / color / mirror / Atom feed
From: Mehmet Fide <mehmet.fide@gmail.com>
To: Luka Gejak <luka.gejak@linux.dev>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
	Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	mehmet.fide@screeningeagle.com
Subject: Re: [PATCH rtw-next v9 2/3] wifi: rtw88: support channel switch in AP mode
Date: Sat, 31 Oct 2026 22:19:29 +0100	[thread overview]
Message-ID: <20261031211929.3296373-1-mehmet.fide@gmail.com> (raw)
In-Reply-To: <7ea86f5208f259f01ce8c18b7701f2a3e41e0fca@linux.dev>

Hi Luka,

Thanks for the review.

> Maybe clear csa_vif again at the end of rtw_core_stop(), once the mutex
> is taken back?

Yes. The USB chips never start the recovery, rtw_fw_c2h_cmd_isr() is
only called from pci.c, so I started it from a test hook on an
RTL8821CU, held rtw_core_stop() open for 3 s with the mutex dropped and
started a switch in that time:

- before the cancels: the countdown never finished and the next switch
  was refused, 3 of 3 runs;
- after cancel_delayed_work_sync(): the work stayed queued with csa_vif
  set, ran after the power off, and the restart then failed to download
  the firmware, 3 of 3 runs.

With csa_vif cleared again after the mutex_lock(), the switch completed
in all 6 runs. v10 does that.

Mehmet

  reply	other threads:[~2026-10-31 21:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 15:29 [PATCH rtw-next v9 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
2026-10-26 15:29 ` [PATCH rtw-next v9 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
2026-10-26 15:29 ` [PATCH rtw-next v9 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
2026-10-30 16:18   ` Luka Gejak
2026-10-31 21:19     ` Mehmet Fide [this message]
2026-10-26 15:29 ` [PATCH rtw-next v9 3/3] wifi: rtw88: time the countdown downloads from the TBTT Mehmet Fide
2026-10-30 16:23   ` Luka Gejak
2026-10-31 21:20     ` Mehmet Fide

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261031211929.3296373-1-mehmet.fide@gmail.com \
    --to=mehmet.fide@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luka.gejak@linux.dev \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox