From: Vladimir Zapolskiy <vz@kernel.org>
To: Jeff Johnson <jjohnson@kernel.org>,
Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Cc: Kalle Valo <kvalo@kernel.org>,
Carl Huang <quic_cjhuang@quicinc.com>,
Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>,
Vasanthakumar Thiagarajan
<vasanthakumar.thiagarajan@oss.qualcomm.com>,
Bhagavathi Perumal S <quic_bperumal@quicinc.com>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
ath12k@lists.infradead.org
Subject: [PATCH v2 0/2] wifi: ath11k/ath12k: Fix MHI leak on power up failure
Date: Sun, 1 Nov 2026 00:40:07 +0200 [thread overview]
Message-ID: <20261031224009.2323055-1-vz@kernel.org> (raw)
If MHI power up fails, for instance due to a missing firmware file, the
MHI device context and the RDDM image table allocated by
mhi_prepare_for_power_up() are leaked on probe error path in both ath11k
and ath12k drivers.
The fixes keep MHI prepared on the power up error path, so a firmware
crash dump collection in the reset work can still read the RDDM image,
and release it on driver unregistration or before MHI is prepared again.
Changes from v1 to v2:
* fixed double unprepare by introducing new "MHI prepared" flag (Baochen),
* added a similar ath12 memory leak fix.
Link to v1:
* https://lore.kernel.org/linux-wireless/20261028104336.1686334-1-vz@kernel.org/
Vladimir Zapolskiy (2):
wifi: ath11k: Unprepare MHI on power up failure
wifi: ath12k: Unprepare MHI on power up failure
drivers/net/wireless/ath/ath11k/mhi.c | 9 ++++++++-
drivers/net/wireless/ath/ath11k/pci.h | 1 +
drivers/net/wireless/ath/ath12k/mhi.c | 14 ++++++++++++++
3 files changed, 23 insertions(+), 1 deletion(-)
--
2.51.0
next reply other threads:[~2026-10-31 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 22:40 Vladimir Zapolskiy [this message]
2026-10-31 22:40 ` [PATCH v2 1/2] wifi: ath11k: Unprepare MHI on power up failure Vladimir Zapolskiy
2026-10-31 22:40 ` [PATCH v2 2/2] wifi: ath12k: " Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261031224009.2323055-1-vz@kernel.org \
--to=vz@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=baochen.qiang@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_bperumal@quicinc.com \
--cc=quic_cjhuang@quicinc.com \
--cc=quic_pradeepc@quicinc.com \
--cc=vasanthakumar.thiagarajan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox