Re: [PATCH wireless-next v2 4/7] wifi: rt2800: don't report an A-MPDU length to minstrel_ht

[Stanislaw Gruszka <stf_xl@wp.pl>]

On Sun, Nov 01, 2026 at 12:51:11AM +0800, Ho Jie Feng wrote:
> Set IEEE80211_HW_TX_STATUS_NO_AMPDU_LEN, which was added for drivers
> that can't report the proper AMPDU length and record this workaround
> below the TODO comment.
> 
> Signed-off-by: Ho Jie Feng <hjf3108@gmail.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>

> ---
>  drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 1 +
>  drivers/net/wireless/ralink/rt2x00/rt2x00dev.c | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> index 5e1ee016624c6..1301bc24d9413 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> @@ -11860,6 +11860,7 @@ static int rt2800_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
>  	ieee80211_hw_set(rt2x00dev->hw, PS_NULLFUNC_STACK);
>  	ieee80211_hw_set(rt2x00dev->hw, SIGNAL_DBM);
>  	ieee80211_hw_set(rt2x00dev->hw, SUPPORTS_PS);
> +	ieee80211_hw_set(rt2x00dev->hw, TX_STATUS_NO_AMPDU_LEN);
>  
>  	/*
>  	 * Don't set IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING for USB devices
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c
> index db33c1215de97..350e6bf24f7aa 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c
> @@ -374,6 +374,8 @@ static void rt2x00lib_fill_tx_status(struct rt2x00_dev *rt2x00dev,
>  	 * by the hw we could provide the real ampdu_len to mac80211
>  	 * which would allow the rc algorithm to better decide on
>  	 * which rates are suitable.
> +	 *
> +	 * Currently, we work around this by setting TX_STATUS_NO_AMPDU_LEN.
>  	 */
>  	if (test_bit(TXDONE_AMPDU, &txdesc->flags) ||
>  	    tx_info->flags & IEEE80211_TX_CTL_AMPDU) {
> -- 
> 2.53.0
>