From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.47 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794813626; b=KpCi4A4rUFYm44YluZPFjK+bwISeM1q9O7ORK9O5AMQHe8ohlqLC+My+5oam7XetYFx8 UiG/HGKLScYvJNTMbJ6fKXZzIIp6bAjfVJaK5lLwHS7cutyyG3IZJJa/x1bFMqVBFBveP YfVrblZDHUfPIcdXPtaU46XiR5ZGhczAberEME0Weon/J4V7Jp9fyRm8lQYpe3mpeUNbL vYnKFa2gSCdcR8cyqrUu/vaGO8V/jKZ8N/nuNaXuwqEFPOa6N4ed/oI6jQGSXQHDfbEHP MvIfw2kwNuoHOSPoD9xDmwTCTRXX/Sd5F/iP65j+oozSekQCZsd4DZ9S6zNPia4Rh4Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794813626; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=d85kdPM6Zryarhegtw0yCCkKuMF5/GaNNr8TE4nytkQ=; b=PTPr8CdW6QgCJ9xWaUbuNfcZihKq2A18kEVW87h3P04zzDGVZ0YbhNpj98Ohk2xOcGFS 3N8TOr3OocjSazhjnJ1T7svFpSKHQXhT25Aqrv7Hvxk7pY8bGr3d0C5IvNmN+1HpAKCsx h3TEMX1+rCDE3JSRFGNnVd+QQ4q6RPGAVSwkiRvv4AX6fSwCB9MQjbcRVJ/s7ElHrot+Y QRuIZzH9NLU4ezSBwEu6xt6U3BsLSWGunKn33oqvSBGbWthuoTc6NKpz4q1grCQBoA7Bq wumMJshZqzRvWwVejxHpCwXKtDFVbVVTiyOms+zuCHKkFlFm6S4SlVruPEoEDjYvAOw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=jhhOowMw; arc=none smtp.remote-ip=209.85.128.47 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 599F3606A31C for ; Mon, 16 Nov 2026 07:20:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 599F3606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=jhhOowMw Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4bb702a7548so4569975e9.1 for ; Sun, 15 Nov 2026 23:20:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794813624; x=1795418424; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=d85kdPM6Zryarhegtw0yCCkKuMF5/GaNNr8TE4nytkQ=; b=jhhOowMwH/LaL7DuII7m0OFDkyCsgWA4Znn5/j3Kdw2HCAGBhQ2ils+cZ7+/KQZP1y wRIZocZs4t1IPDai18WEOm+OwbJQUkj3wtEMaKleYfHzrter2w5edPNfrRUcNlbEbzzV aVZ7uKBVV5mH8GYuN95LBV2PdA1X9YWAUkSu1gfL1R3vzaxzBruqWnAgT98RY3KMzUTf +7D4RY/qYMbjbTMrPoyJs98u77+TZOPgOV60TlY+z/dEwhfOGhE5XSYaT1Hlx+5+OIZW 7BJxl74bk4AanzM2wFF4KAYyRGA14yZL21tonyvt1WvrlHfauy13pEGFG9s0FOXsl6m0 tIAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794813624; x=1795418424; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=d85kdPM6Zryarhegtw0yCCkKuMF5/GaNNr8TE4nytkQ=; b=vymJkvS7Eu6OEgBeYBsjdK6GDEmtaTgSukOo3XpVvPvMhJ7i+ZMx8axHCJcZst3AJT jZ0hAMTQkiagMjy7TxTUVHxO/9jYByCtTTAQqmhWgwrwNSN4yO40oAEilZDxhDNoMl+W 01GI6JxwUIUbu/eRhXvIS6aH0/xaUKg4Yc9p90TVN9MwIwODYmV1qpwKxj5RppFWCn6y sk/ilENVL+2A9NNvLvnFGWe1WAuhxHN5RrtpLei4ZlKO73W8FGT+LXGZbdS2sDN/WViF JOON22J1ClkHtPTYQrQmY3xeWAaAp/NAhCn8qcNvo9vFf3F2ktGagT89neiZNa4Z/SQD uQcA== X-Forwarded-Encrypted: i=1; AL+hErGuBL8IpPwrtL9ahzQ4fJTVNdawgMhtJPf71zMU/iQhWPHG7qO4hAjomUSRc7JOixrwPIWH+OrZFXKQBsbQ6Q==@vger.kernel.org X-Gm-Message-State: APuU4Z+ctdpBr2+jN4/ikhTKgzNvUxVL5veat/i+lhx8NLBYoTSORmRd jMaH+tHkPvMYQb4EzjQi0hW49/EojNqvrbmdkYq+iHQorXfe3wP1dDrp X-Gm-Gg: AYBFou2uPXq+a7MLVsvgoW0JxsS1rFDZjYO3BPZis5bAcom3tVtoJHfQxC1/k8LdjUu buqxRKQsvFQcxVwzmirEcNgAQb3VfagcwIuzUvYw3t5K2wqtr9PStkDpjFzzAh9WGINl7eOUFXo wNwPel+6sh2T9MSedrYSyhi9vTisCVSGlK/tbV+uE0+OdOkLc4HF3mg1y/HLqZgtrQforkTucYl eNjVNLV1jK64fQ9u7w3SUq02lca+kmGg1ckP9NYCi1HLEn6cDebCFU5ym7wCwCZo7Kr1huOhr4p /OIMkb+fywVqgj3ax3TYEPNEL+kbDr/xH5cAX5I9lxosajTZIPR+lt7g+dptwTkMbekQw5I52XV PbcsVpN8SHXhe5Z/G3kWaunnBHZbM3EaipQkNUdwW4UNPrXOKw2UlqSrIwpdTchrzYCVXuhFXsv QgQ+eVcB9NRsmy/YXa0t3NM6VTP6fHihHiroHlP2SleVihwuz9jfYIgv9b6hL5rhs8wMgiERlXr wwqbmUIDKDnpMVnrP1CKqsYgZF47Nu78Hj1Tj+OsLtYJHqeXsCSvmEIqJ1MGyKjWyt9d+agW+0F nz9kofT3/D97szeNNhEhS/OFFXmgcj0zFOQ= X-Received: by 2002:a05:600c:3115:b0:4a3:59c9:a758 with SMTP id 5b1f17b1804b1-4bb55aa4935mr202184665e9.32.1794813623448; Sun, 15 Nov 2026 23:20:23 -0800 (PST) Received: from deb05.proceq.com ([213.160.61.66]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb56689bc2sm159710565e9.2.2026.11.15.23.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Nov 2026 23:20:22 -0800 (PST) From: Mehmet Fide To: Ping-Ke Shih Cc: Luka Gejak , Bitterblue Smith , Yan-Hsuan Chuang , Kalle Valo , Stanislaw Gruszka , Brian Norris , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, mehmet.fide@screeningeagle.com Subject: [PATCH rtw-next] wifi: rtw88: program the beacon interval Date: Mon, 16 Nov 2026 08:20:21 +0100 Message-ID: <20261116072022.1142783-1-mehmet.fide@gmail.com> X-Mailer: git-send-email 2.56.0 X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mehmet Fide The driver never writes the beacon interval register, so the hardware keeps its default of 100 TU. An AP started with another interval says that interval in its beacons and sends them 100 TU apart. With beacon_int=200 in hostapd the beacons of an RTL8822CE, RTL8822CU, RTL8822BU and RTL8821CU are 102.4 ms apart on the air. Write the interval when mac80211 sets it. The beaconing interface is always on port 0: rtw_core_port_switch() moves an AP there. Reported-by: Luka Gejak Closes: https://lore.kernel.org/linux-wireless/1D396970-35B7-4B0B-82E9-24B523AD69C2@linux.dev/ Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver") Signed-off-by: Mehmet Fide --- Notes: Tested on rtw-next on an RTL8822CE, RTL8822CU, RTL8822BU and RTL8821CU as AP with hostapd, the beacons sniffed from a second machine: with beacon_int 50, 100 and 200 they are 51.2, 102.4 and 204.8 ms apart on the air. AP, association, power save, firmware crash and scan tests on the same chips on both bands gave no new kernel report. drivers/net/wireless/realtek/rtw88/mac80211.c | 4 ++++ drivers/net/wireless/realtek/rtw88/reg.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c index 5e40cf06a9e3..5f411df5586e 100644 --- a/drivers/net/wireless/realtek/rtw88/mac80211.c +++ b/drivers/net/wireless/realtek/rtw88/mac80211.c @@ -432,6 +432,10 @@ static void rtw_ops_bss_info_changed(struct ieee80211_hw *hw, if (changed & BSS_CHANGED_BEACON_INT) { if (ieee80211_vif_type_p2p(vif) == NL80211_IFTYPE_STATION) coex_stat->wl_beacon_interval = conf->beacon_int; + else if (vif->type != NL80211_IFTYPE_STATION && + rtwvif->port == RTW_PORT_0) + rtw_write16(rtwdev, REG_MBSSID_BCN_SPACE, + conf->beacon_int); } if (changed & BSS_CHANGED_BEACON) { diff --git a/drivers/net/wireless/realtek/rtw88/reg.h b/drivers/net/wireless/realtek/rtw88/reg.h index afcdb66fdb9a..877b82640e91 100644 --- a/drivers/net/wireless/realtek/rtw88/reg.h +++ b/drivers/net/wireless/realtek/rtw88/reg.h @@ -498,6 +498,7 @@ #define BIT_EN_BCN_FUNCTION BIT(3) #define BIT_EN_TXBCN_RPT BIT(2) #define REG_BCN_CTRL_CLINT0 0x0551 +#define REG_MBSSID_BCN_SPACE 0x0554 #define REG_DRVERLYINT 0x0558 #define REG_BCNDMATIM 0x0559 #define REG_ATIMWND 0x055A base-commit: 61a5eb87b2d9b4d5e353780b781cf691f39ba9e1 -- 2.56.0