Linux wireless drivers development
 help / color / mirror / Atom feed
From: Vincent Schurink <spam@acio.nl>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org, Vincent Schurink <spam@acio.nl>
Subject: [PATCH rtw-next v4] wifi: rtw89: set RA init rate level when the station RSSI is known
Date: Mon, 16 Nov 2026 09:17:41 +0100	[thread overview]
Message-ID: <20261116081741.51039-1-spam@acio.nl> (raw)

When a station associates to an AP, the AP does not know the RSSI of
the station yet. Thus, rtw89_phy_ra_assoc() sends init_rate_lv 0 to the
firmware. With this value, the firmware RA of RTL8922A often uses 20 MHz
and VHT-MCS 2 for the station. It does not try a higher rate, also when
the PER is 0. On an 80 MHz AP, the TCP throughput to the station
then stays at approximately 36 Mbit/s for the full connection.

Move the mapping from RSSI to init_rate_lv to a function. Use it in the
RA association and in the RA update. In a test on RTL8922A, the
firmware used init_rate_lv only together with upd_all, and upd_all
resets the RA context. Thus, the RA
association sets rssi_unknown in the RA info when the RSSI is not known.
The RA update then sets upd_all one time, when the RSSI is known.
The flag is in a struct_group at the end of the RA info, and
rtw89_phy_ra_sta_update() clears the RA info only up to this group.
Thus, the flag stays until the RA update uses it.

Tested on RTL8912AU (RTL8922A, USB) in AP mode with hostapd 2.10 and
VHT 80 MHz. The client is an Intel Meteor Lake CNVi (iwlwifi) at -38 to
-40 dBm. Each test reconnects the client, then sends TCP from the AP for
60 s.
Before: 6 of 8 connections stay at VHT-MCS 2 and 20 MHz, 36 Mbit/s.
After: 8 of 8 connections use VHT-MCS 7 to 9 at 80 MHz, 668 to
684 Mbit/s.

Suggested-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Vincent Schurink <spam@acio.nl>
---
v4:
- Move the flag from struct rtw89_sta_link to the end of struct
  rtw89_ra_info, in a struct_group with a comment, as suggested by
  Ping-Ke.
- rtw89_phy_ra_sta_update() clears the RA info only up to this group,
  with offsetof(), as suggested by Ping-Ke. rssi_unknown is a plain bool
  and not a bit-field, because offsetof() cannot be used on a bit-field.
- RSSI 1 also sets the flag. As Ping-Ke wrote, this is harmless.
- Rebase on rtw-next 61a5eb87b2d.
- checkpatch --strict reports "Alignment should match open parenthesis"
  for the member in struct_group(). With alignment to the parenthesis,
  checkpatch reports "Statements should start on a tabstop" instead.
- Tested again with v4. The client is at -39 to -40 dBm, 60 s per
  connection. 8 of 8 connections use 80 MHz (VHT 2SS MCS 7 to 9), 668 to
  684 Mbit/s. PMF still works: the client accepts a protected broadcast
  deauthentication.
- Not tested on AX chips. On AX chips, the RA update sends upd_all
  without the CSI fields. Also, the RA update now sends init_rate_lv 1
  to 3 instead of 0 on all chips. In the v2 test on RTL8922A, this had
  no effect without upd_all.

v3: https://lore.kernel.org/linux-wireless/20261113080731.30155-1-spam@acio.nl/
v2: https://lore.kernel.org/linux-wireless/20261112075622.32785-1-spam@acio.nl/
v1: https://lore.kernel.org/linux-wireless/20261108131723.206533-1-spam@acio.nl/

 drivers/net/wireless/realtek/rtw89/core.h |  5 ++++
 drivers/net/wireless/realtek/rtw89/phy.c  | 32 ++++++++++++++++-------
 2 files changed, 27 insertions(+), 10 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
index 7f84ee59f825..df702f4420bb 100644
--- a/drivers/net/wireless/realtek/rtw89/core.h
+++ b/drivers/net/wireless/realtek/rtw89/core.h
@@ -4626,6 +4626,11 @@ struct rtw89_ra_info {
 	u8 macid_msb:2;
 	u8 band:2; /* enum rtw89_band */
 	u8 is_new_dbgreg:1;
+
+	/* keep driver helpers below in group (not cleared by rtw89_phy_ra_sta_update()) */
+	struct_group(helpers,
+		bool rssi_unknown;
+	);
 };
 
 #define RTW89_PPDU_MAC_INFO_USR_SIZE 4
diff --git a/drivers/net/wireless/realtek/rtw89/phy.c b/drivers/net/wireless/realtek/rtw89/phy.c
index 795920b899d9..441568573624 100644
--- a/drivers/net/wireless/realtek/rtw89/phy.c
+++ b/drivers/net/wireless/realtek/rtw89/phy.c
@@ -343,7 +343,7 @@ static void rtw89_phy_ra_sta_update(struct rtw89_dev *rtwdev,
 	bool sgi = false;
 	bool fix_giltf_en = false;
 
-	memset(ra, 0, sizeof(*ra));
+	memset(ra, 0, offsetof(typeof(*ra), helpers));
 	/* Set the ra mask from sta's capability */
 	if (link_sta->eht_cap.has_eht) {
 		mode |= RTW89_RA_MODE_EHT;
@@ -502,6 +502,20 @@ static void rtw89_phy_ra_sta_update(struct rtw89_dev *rtwdev,
 	ra->csi_mode = csi_mode;
 }
 
+static u8 rtw89_phy_ra_get_init_rate_lv(struct rtw89_sta_link *rtwsta_link)
+{
+	u8 rssi = ewma_rssi_read(&rtwsta_link->avg_rssi) >> RSSI_FACTOR;
+
+	if (rssi > 40)
+		return 1;
+	if (rssi > 20)
+		return 2;
+	if (rssi > 1)
+		return 3;
+
+	return 0;
+}
+
 void rtw89_phy_ra_update_sta_link(struct rtw89_dev *rtwdev,
 				  struct rtw89_sta_link *rtwsta_link,
 				  u32 changed)
@@ -519,6 +533,11 @@ void rtw89_phy_ra_update_sta_link(struct rtw89_dev *rtwdev,
 
 	rcu_read_unlock();
 
+	ra->init_rate_lv = rtw89_phy_ra_get_init_rate_lv(rtwsta_link);
+	if (ra->rssi_unknown && ra->init_rate_lv) {
+		ra->upd_all = 1;
+		ra->rssi_unknown = false;
+	}
 	if (changed & IEEE80211_RC_SUPP_RATES_CHANGED)
 		ra->upd_mask = 1;
 	if (changed & (IEEE80211_RC_BW_CHANGED | IEEE80211_RC_NSS_CHANGED))
@@ -733,7 +752,6 @@ void rtw89_phy_ra_assoc(struct rtw89_dev *rtwdev, struct rtw89_sta_link *rtwsta_
 	struct rtw89_vif_link *rtwvif_link = rtwsta_link->rtwvif_link;
 	struct ieee80211_vif *vif = rtwvif_link_to_vif(rtwvif_link);
 	struct rtw89_ra_info *ra = &rtwsta_link->ra;
-	u8 rssi = ewma_rssi_read(&rtwsta_link->avg_rssi) >> RSSI_FACTOR;
 	struct ieee80211_link_sta *link_sta;
 	bool csi;
 
@@ -747,14 +765,8 @@ void rtw89_phy_ra_assoc(struct rtw89_dev *rtwdev, struct rtw89_sta_link *rtwsta_
 
 	rcu_read_unlock();
 
-	if (rssi > 40)
-		ra->init_rate_lv = 1;
-	else if (rssi > 20)
-		ra->init_rate_lv = 2;
-	else if (rssi > 1)
-		ra->init_rate_lv = 3;
-	else
-		ra->init_rate_lv = 0;
+	ra->init_rate_lv = rtw89_phy_ra_get_init_rate_lv(rtwsta_link);
+	ra->rssi_unknown = !ra->init_rate_lv;
 	ra->upd_all = 1;
 	rtw89_debug(rtwdev, RTW89_DBG_RA,
 		    "ra assoc: macid = %d, mode = %d, bw = %d, nss = %d, lv = %d",
-- 
2.53.0


             reply	other threads:[~2026-11-16  8:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  8:17 Vincent Schurink [this message]
2026-11-16  8:33 ` [PATCH rtw-next v4] wifi: rtw89: set RA init rate level when the station RSSI is known Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116081741.51039-1-spam@acio.nl \
    --to=spam@acio.nl \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox