From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.219.43 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794835249; b=jUjADrs4nduyOObhydRx3OR3wUYTHaucV527AAqeKP74LTmS6/xdw8xYBerMuBCq3BUn Z1VwBdG5GciZCFC/Nnlzl6sCCbty/TXUx1vqMh8aGbbv6zFLXY42K5qmxxwU5RXANQtYT QkMQK8ZwANQPJwlSHm0nUaAUJcA/kCgDnUBHAFjBYp/QdCKFEpS90pLnrc+arjRwSLUHV 88NJnUG5O1GUiEXyrJDnsQboEpoAayCy31yrFPzjjNGZVVTKZ034+Yu9+c81z0ypV1UPv 8by4Vn1yZGfyAAGn2TNoTb0Lwf7SEcjxOGUtBi9QnKPr6pUjcL4IYzbIPj3du9/FcjA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794835249; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=pW6Ljdl+VPjn0HqbJ5aXeG19kylCTPtUMbKY6fBA+PE=; b=rzaz7xOanooGr2yVKODY1F6sXe7FGpFuvrOoBpw1pGQjuXcHbR2p+5RzmgBHUVjnxwSG JFGta0Gs144XcsWoAxu0OuvqIPWXLIjCpitK9aNiSr3GkZ9KbluC9bTUU/d/5UOvmUJhb zU6zGXslfY1f1s2+zdPIq67JCikkFvXcjT5CLXVaqDAcKunaAStJhHodgqgf2rVyZ5lsI lprW52tOmEOJ8abbTCJVhm8fsBYIjQtc3Sju6EbYDlrHblr/PocDiXUaVG2WhhmiTEc4G hzAn6F8t4Ib0h7VQQiJ7s+HfD/qfIiNxg4LBN6uGghPmn/3YR9neZGXThAw+nR/+XHQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=F00eXo5h; arc=none smtp.remote-ip=209.85.219.43 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ADEA606A334 for ; Mon, 16 Nov 2026 13:20:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4ADEA606A334 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=F00eXo5h Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-91f23ddf32fso23834636d6.0 for ; Mon, 16 Nov 2026 05:20:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1794835248; x=1795440048; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=pW6Ljdl+VPjn0HqbJ5aXeG19kylCTPtUMbKY6fBA+PE=; b=F00eXo5hK7MhiGIzcy2xEZvXaOlU++0SsxWdg8F2eYgLj0IP/wqxNHSj70WYC1UCbD vmKPyn8zqLHpLHOvxkTPyXLn/laMAvSaSbXM05SN4tjv6Cx+GcVaR0GxUXpMgXzGykx3 FokKvpAfMx6w/qg4Q5h79shuv6MexzGsY/vmut+9b8A8pQsaE0GfSqy0kYc2aGWEaEae 3xYzyobXgBsc03sh3wdT6H/0kLtFYOlPUaVehm8clJUf4d9zj9Hfn5kvjyTiGQDD3sEC 6wk4kHeXw7a4jDhfFMIm7aNEb1ZQhwAt5xztT2KrBS1HRA1ERCFKDcAKt5g1NH70HZ/q daJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794835248; x=1795440048; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pW6Ljdl+VPjn0HqbJ5aXeG19kylCTPtUMbKY6fBA+PE=; b=nCDcLog8xqIRj6cRg9+t/1+AMP85U8iIuf1u9wTg8q4KXlmzVJRTB5sSlcwGShck3Q cjZBHrs1i3pu8CziJsRXnW1fdE7Ztq9DIvoPhXJGSM3jVWQFd/JY8qVvnOVCfJy40jAA /EJpDl7REVjMsS6qI9VmfhxNm1R2W+LmqguzuI9elqeaxln8nKN+cA+wli1bd0mbBdY9 N5L12o6Q24n1oCKN8ccRd28hF+EMm+iId/CDK3ZXT3FfIoCwTDj7WafWBuAAHl6WpEwb wJrBLKw5P3ipH7uLaWy7AvQoD2DZgSiDbvlAsmJnBh8mPXdHtBy3BGeFQjcixp7qpHpl h1NA== X-Forwarded-Encrypted: i=1; AL+hErGm7l5g6iTbjjn2oySO6avd+gLkE0dGxM3hFsp/Jr8MQUt+8np5WQvMXf2agbZ5ie83pa9jHJ8EiozKOArgVA==@vger.kernel.org X-Gm-Message-State: APuU4Z/bU54dOCMfNaDM9MmFg9/fhfcZYNTGL35VgPCEVdqAmqXKuXyZ 5NeH6m102xYaqNtGv3xIprKG5zCcnNH6E52h+MjSLAYHrPdlBu5q3ea58GERGEeqcxs= X-Gm-Gg: AZFdTZceq4mxEUs7Ym3FlenPGaBAWyVTcpPA5AGsigoIbpDr2SmT5d3/6wrjTeMMtBL y9tvadbu1D1DCcS4KVOj7gun8grOX4GVtLyTOVSbRjq3vBL+B55NQGSmJyDQjAZU/72wrB0/zUF A+SCIW0M5HyqZkkC6roQimvpjVfs8JRmfa++8hALGfAhBI9iBANME1xTNwtOvlbGHmzwBLhxfCV 5oSo8HAuRuUTQD24VeiEvCCuM14mrPPnkubpMTHn9hBkZcu/xcHBRgJ/A8OSonrpq6Gcz09T2WY 8HVJ6exWiEROWseAYikAD6CIEOOgAHEuN2EYZwWOKacMPJ59hC97PDJVpC2kjHe+00LSWhSnwq8 ZeufBqmB3iN4cdJKBQABE8ByOWHLg+Ms3n8tUcWVhj4nU0ePPBireM5nRT/N37mUTBn0Q1cuN0m 3j6MNfTTSSBHEjT6nrQfoPXUt29e/3YveUZobk+73AmOb/QodtW0yQHualJ7HCXWKMzw3+FpJ1d DnGBJzEmXWZvqH3J07lWbQaUAVRqLMa3afw7SMUG/qgnwdDPzmIQF++Neftfam+NhNS4Ik7xRiB iP8JOA== X-Received: by 2002:ad4:5744:0:b0:91f:3230:2a4 with SMTP id 6a1803df08f44-91f32300351mr126741416d6.53.1794835247815; Mon, 16 Nov 2026 05:20:47 -0800 (PST) Received: from ziepe.ca ([142.166.156.71]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-91f23d7ba48sm85758876d6.28.2026.11.16.05.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 05:20:47 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1xSwda-00000009KhK-1awf; Mon, 16 Nov 2026 09:20:46 -0400 Date: Mon, 16 Nov 2026 09:20:46 -0400 From: Jason Gunthorpe To: "Aneesh Kumar K.V" Cc: Leon Romanovsky , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Dmitry Torokhov , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Johannes Berg , Jonathan Corbet , Shuah Khan , Randy Dunlap , Bjorn Helgaas , "Joerg Roedel (AMD)" , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , Robin Murphy , David Woodhouse , Lu Baolu , Johan Hovold , Eric Dumazet , Marcel Holtmann , Luiz Augusto von Dentz , Nipun Gupta , Nikhil Agarwal , Pieter Jansen van Vuuren , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, iommu@lists.linux.dev Subject: Re: [PATCH 17/17] PCI: Replace untrusted state with device trust Message-ID: <20261116132046.GI2532299@ziepe.ca> References: <20261105-device-trust-core-v1-0-1e536825b4eb@nvidia.com> <20261105-device-trust-core-v1-17-1e536825b4eb@nvidia.com> X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 16, 2026 at 06:38:25PM +0530, Aneesh Kumar K.V wrote: > > +static inline bool > > +pci_dev_default_is_restricted(const struct pci_dev *pdev) > > +{ > > + enum device_trust_policy policy = READ_ONCE(pdev->dev.trust_policy); > > + > > + return policy == DEVICE_TRUST_POLICY_DISABLED || > > + policy == DEVICE_TRUST_POLICY_ADVERSARY; > > +} > > + > > Could you clarify how this series will work alongside device acceptance > and private-memory access? > > In particular, what should callers of device_cc_accepted() use under > this model? Who is calling device_cc_accepted? I thought we were keeping that internal to the DMA PI? > My understanding is that trust describes the operating > policy, not TDISP acceptance or DMA access to private memory. Right. > Therefore, > neither FULL nor ADVERSARY alone indicates whether a device can access > private memory? Right. Once you turn on TDISP you effectively activate DMA, just like turning on the IOMMU. Userspace then gets to choose how the rest of the system behavess. You can still run a strict viommu with an adversarial driver even if you enabled TDISP and can DMA to all memory. I don't know if many people would choose that combination, but it is there. > You also mention that once a trust level other than DISABLED is set, it > cannot be changed during the device's lifetime. If a device initially > operates in ADVERSARY mode and later attestation justifies FULL > operation, is that transition intentionally unsupported for the existing > device object? As documented, unbind/rebind and reset preserve the > committed level. I think it should only be for the duration of a bound driver? > It would help to describe how the trust framework fits together with > those separate mechanisms, including which pieces are left for follow-up > series. The main thing it brings is the pause to allow userspace to measure the device and put it into RUN if it so chooses before any driver is bound. It doesn't change how any of the DMA or TDSIP flows work. Jason