From: Mehmet Fide <mehmet.fide@gmail.com>
To: Luka Gejak <luka.gejak@linux.dev>,
Zong-Zhe Yang <kevin_yang@realtek.com>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
Tzu-En Huang <tehuang@realtek.com>,
Yan-Hsuan Chuang <yhchuang@realtek.com>,
Kalle Valo <kvalo@kernel.org>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Brian Norris <briannorris@chromium.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
mehmet.fide@screeningeagle.com
Subject: Re: [PATCH rtw-next v3 1/5] wifi: rtw88: free the reserved pages of an interface on firmware recovery
Date: Fri, 20 Nov 2026 18:01:54 +0100 [thread overview]
Message-ID: <20261120170154.374502-1-mehmet.fide@gmail.com> (raw)
In-Reply-To: <20261120131000.33858-1-luka.gejak@linux.dev>
Hi Luka,
> Could this skip a download that WoWLAN needs? If suspend flushes the
> recovery work while it holds RTNL, ieee80211_restart_work() cannot add
> the interfaces back before rtw_wow_suspend() runs.
Yes. On an RTL8822CE with net detect configured, a firmware crash
forced right before suspend made rtw_wow_suspend() run with no port in
use. The download was skipped and the driver logged "failed to get
probe_req rsvd loc".
> I think the empty list warning can still happen with AP and station
> interfaces on the RTL8822C.
It can. With the window widened by a test build, a station interface
brought up during the recovery got port 0, and a queued beacon update
then hit "Should not have an empty reserved page".
v4 follows Zong-Zhe's suggestion: the reset no longer frees the pages,
rtw_ops_add_interface() frees the old pages of an interface that was
already initialized, and both port checks go away. The lists then stay
filled through the recovery, and the TIM update you raised on v2 is
not skipped. I will run both tests above again on v4.
Mehmet
next prev parent reply other threads:[~2026-11-20 17:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 17:09 [PATCH rtw-next v3 0/5] wifi: rtw88: fixes around the firmware recovery Mehmet Fide
2026-11-17 17:09 ` [PATCH rtw-next v3 1/5] wifi: rtw88: free the reserved pages of an interface on " Mehmet Fide
2026-11-20 13:09 ` Luka Gejak
2026-11-20 17:01 ` Mehmet Fide [this message]
2026-11-17 17:10 ` [PATCH rtw-next v3 2/5] wifi: rtw88: report the frames purged from the TX report queue Mehmet Fide
2026-11-20 13:09 ` Luka Gejak
2026-11-20 17:02 ` Mehmet Fide
2026-11-17 17:10 ` [PATCH rtw-next v3 3/5] wifi: rtw88: do not drop stations when collecting them for an iteration Mehmet Fide
2026-11-20 13:09 ` Luka Gejak
2026-11-20 17:02 ` Mehmet Fide
2026-11-17 17:10 ` [PATCH rtw-next v3 4/5] wifi: rtw88: reset the stations outside of RCU on firmware recovery Mehmet Fide
2026-11-17 17:10 ` [PATCH rtw-next v3 5/5] wifi: rtw88: clear the restart flag when the device is stopped Mehmet Fide
2026-11-17 23:15 ` Mehmet Fide
2026-11-18 0:45 ` Ping-Ke Shih
2026-11-19 14:31 ` [PATCH rtw-next v3 0/5] wifi: rtw88: fixes around the firmware recovery Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120170154.374502-1-mehmet.fide@gmail.com \
--to=mehmet.fide@gmail.com \
--cc=briannorris@chromium.org \
--cc=kevin_yang@realtek.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=mehmet.fide@screeningeagle.com \
--cc=pkshih@realtek.com \
--cc=sgruszka@redhat.com \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox