Linux wireless drivers development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Jeff Johnson <jjohnson@kernel.org>,
	 Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	 Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	 linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
	ath12k@lists.infradead.org,  linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH ath-next v3 05/15] wifi: ath12k: add Wi-Fi 8 directory and base module scaffolding
Date: Sat, 21 Nov 2026 13:29:38 +0100	[thread overview]
Message-ID: <20261121-objective-turquoise-sponge-f91ff2@quoll> (raw)
In-Reply-To: <20261118-wifi8_qcn9575_bringup-v3-5-9875d2a3953f@oss.qualcomm.com>

On Wed, Nov 18, 2026 at 01:45:28PM +0530, Madhavan Ganesan wrote:
> QCN9575 is a Wi-Fi 8 target with a distinct hardware family that cannot
> share the Wi-Fi 7 module. Add a dedicated wifi8/ subdirectory to host
> QCN9575-specific code. Introduce Wi-Fi 8 build rules, base module source
> files (wifi8/core.c, wifi8/pci.c, wifi8/pci.h), and add
> ATH12K_DEVICE_FAMILY_WIFI8 to ath12k_device_family. Keep Wi-Fi 8 PCI
> init/exit as stubs so the module builds cleanly and remains bisect-safe;
> actual PCI driver registration and hardware support come in follow-up
> patches.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
> 
> Signed-off-by: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>
> ---
>  drivers/net/wireless/ath/ath12k/Makefile       |  1 +
>  drivers/net/wireless/ath/ath12k/core.h         |  1 +
>  drivers/net/wireless/ath/ath12k/wifi8/Makefile |  4 ++++
>  drivers/net/wireless/ath/ath12k/wifi8/core.c   | 31 ++++++++++++++++++++++++++
>  drivers/net/wireless/ath/ath12k/wifi8/pci.c    | 18 +++++++++++++++
>  drivers/net/wireless/ath/ath12k/wifi8/pci.h    | 11 +++++++++
>  6 files changed, 66 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/Makefile b/drivers/net/wireless/ath/ath12k/Makefile
> index 861ec85eebed..332110d72a1d 100644
> --- a/drivers/net/wireless/ath/ath12k/Makefile
> +++ b/drivers/net/wireless/ath/ath12k/Makefile
> @@ -25,6 +25,7 @@ ath12k-y += core.o \
>  ath12k-$(CONFIG_ATH12K_AHB) += ahb.o pcic.o
>  
>  obj-$(CONFIG_ATH12K) += wifi7/
> +obj-$(CONFIG_ATH12K) += wifi8/
>  
>  ath12k-$(CONFIG_ATH12K_DEBUGFS) += debugfs.o debugfs_htt_stats.o debugfs_sta.o
>  ath12k-$(CONFIG_ACPI) += acpi.o
> diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h
> index a8e8a55aa718..2a4b5e5e1af3 100644
> --- a/drivers/net/wireless/ath/ath12k/core.h
> +++ b/drivers/net/wireless/ath/ath12k/core.h
> @@ -956,6 +956,7 @@ struct ath12k_mem_profile_based_param {
>  enum ath12k_device_family {
>  	ATH12K_DEVICE_FAMILY_START,
>  	ATH12K_DEVICE_FAMILY_WIFI7 = ATH12K_DEVICE_FAMILY_START,
> +	ATH12K_DEVICE_FAMILY_WIFI8,
>  	ATH12K_DEVICE_FAMILY_MAX,
>  };
>  
> diff --git a/drivers/net/wireless/ath/ath12k/wifi8/Makefile b/drivers/net/wireless/ath/ath12k/wifi8/Makefile
> new file mode 100644
> index 000000000000..b8c5b6d3a7bd
> --- /dev/null
> +++ b/drivers/net/wireless/ath/ath12k/wifi8/Makefile
> @@ -0,0 +1,4 @@
> +# SPDX-License-Identifier: BSD-3-Clause-Clear
> +obj-$(CONFIG_ATH12K) += ath12k_wifi8.o
> +ath12k_wifi8-y += core.o \
> +		  pci.o
> diff --git a/drivers/net/wireless/ath/ath12k/wifi8/core.c b/drivers/net/wireless/ath/ath12k/wifi8/core.c
> new file mode 100644
> index 000000000000..9253ef9d9cf5
> --- /dev/null
> +++ b/drivers/net/wireless/ath/ath12k/wifi8/core.c
> @@ -0,0 +1,31 @@
> +// SPDX-License-Identifier: BSD-3-Clause-Clear
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include <linux/module.h>
> +#include "../pci.h"
> +#include "pci.h"
> +
> +static int ath12k_wifi8_init(void)
> +{
> +	int ret;
> +
> +	ret = ath12k_wifi8_pci_init();
> +	if (ret)
> +		pr_warn("Failed to register ath12k Wi-Fi 8 PCI driver: %d\n",
> +			ret);
> +
> +	return ret;
> +}
> +
> +static void ath12k_wifi8_exit(void)
> +{
> +	ath12k_wifi8_pci_exit();
> +}
> +
> +module_init(ath12k_wifi8_init);
> +module_exit(ath12k_wifi8_exit);
> +
> +MODULE_DESCRIPTION("Driver support for Qualcomm Technologies 802.11bn WLAN devices");
> +MODULE_LICENSE("Dual BSD/GPL");
> diff --git a/drivers/net/wireless/ath/ath12k/wifi8/pci.c b/drivers/net/wireless/ath/ath12k/wifi8/pci.c
> new file mode 100644
> index 000000000000..3975081d167b
> --- /dev/null
> +++ b/drivers/net/wireless/ath/ath12k/wifi8/pci.c
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: BSD-3-Clause-Clear
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include <linux/pci.h>
> +
> +#include "pci.h"
> +
> +int ath12k_wifi8_pci_init(void)
> +{
> +	/* Wi-Fi 8 PCI driver registration will be added in follow-up patches. */

That's dead code and dead comment. Why are you adding comment which at
this point is not correct?

Commits represent logical chunks of bringing device support and above is
not logical. It's empty and achieve nothing.

Do not create stubs just for sakeness of having stubs (or worse - commits)

Best regards,
Krzysztof


  reply	other threads:[~2026-11-21 12:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  8:15 [PATCH ath-next v3 00/15] wifi: ath12k: add initial Wi-Fi 8 support for QCN9575 Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 01/15] dt-bindings: net: wireless: add ath12k wifi device QCN9575 Madhavan Ganesan
2026-11-21 12:37   ` Krzysztof Kozlowski
2026-11-18  8:15 ` [PATCH ath-next v3 02/15] wifi: ath12k: refactor PCI window selection to per-device layout Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 03/15] wifi: ath12k: add extended QMI WLAN cfg for CE and service pipes Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 04/15] wifi: ath12k: add QMI support for extended firmware binary download Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 05/15] wifi: ath12k: add Wi-Fi 8 directory and base module scaffolding Madhavan Ganesan
2026-11-21 12:29   ` Krzysztof Kozlowski [this message]
2026-11-18  8:15 ` [PATCH ath-next v3 06/15] wifi: ath12k: add initial Wi-Fi 8 hw params and init helper for QCN9575 Madhavan Ganesan
2026-11-21 12:31   ` Krzysztof Kozlowski
2026-11-21 12:33   ` Krzysztof Kozlowski
2026-11-18  8:15 ` [PATCH ath-next v3 07/15] wifi: ath12k: add Wi-Fi 8 HAL register table and hal init hook " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 08/15] wifi: ath12k: add Wi-Fi 8 HAL ops and descriptor definitions " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 09/15] wifi: ath12k: add unified firmware image support " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 10/15] wifi: ath12k: add Wi-Fi 8 MHI config " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 11/15] wifi: ath12k: add Wi-Fi 8 CE config and service pipe map " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 12/15] wifi: ath12k: add Wi-Fi 8 WMI init " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 13/15] wifi: ath12k: add Wi-Fi 8 hw ops " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 14/15] wifi: ath12k: add and hook Wi-Fi 8 mac80211 ops skeleton " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 15/15] wifi: ath12k: add Wi-Fi 8 PCI driver scaffolding " Madhavan Ganesan
2026-11-21 12:28   ` Krzysztof Kozlowski
2026-11-21 12:34   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121-objective-turquoise-sponge-f91ff2@quoll \
    --to=krzk@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jjohnson@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=justinstitt@google.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=madhavan.ganesan@oss.qualcomm.com \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox