From: govinds@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 1/4] ath11k: Add PCI client driver for QCA6390 chipset
Date: Tue, 12 May 2020 11:01:09 +0530 [thread overview]
Message-ID: <2028987516458b3145d3cd9758eafe8f@codeaurora.org> (raw)
In-Reply-To: <87h7wm4akt.fsf@kamboji.qca.qualcomm.com>
Hi Kalle,
On 2020-05-11 23:29, Kalle Valo wrote:
> Govind Singh <govinds@codeaurora.org> writes:
>
>> QCA6390 is PCI based 11ax chipset, add
>> pci client driver for QCA6390 target.
>>
>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>
> This patch had multiple problems, most important ones were:
>
> * a break missing in ath11k_pci_probe()
>
My bad. Thanks for fixing same.
> * it's not possible to have static variables in .h files, I fixed by
> moving the ring variables to core.c in a separate patch:
>
> https://patchwork.kernel.org/patch/11541355/
>
> * this patch didn't link (at least when compiling as modules), I fixed
> those by adding missing EXPORT_SYMBOL() macros
>
Looks, this is required after moving the ring mask from ahb to core.
> Please double check my changes:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=44a28b572070f578914367dc2469cef48ece13f4
Looks good to me.
BR,
Govind
next prev parent reply other threads:[~2020-05-12 5:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 8:58 [PATCH 0/4] Add PCI client driver for QCA6390 chipset Govind Singh
2020-05-08 8:58 ` [PATCH 1/4] ath11k: " Govind Singh
2020-05-11 17:59 ` Kalle Valo
2020-05-12 5:31 ` govinds [this message]
2020-05-08 8:58 ` [PATCH 2/4] ath11k: setup pci resource for QCA6390 target Govind Singh
2020-05-08 8:58 ` [PATCH 3/4] ath11k: Add msi config init for QCA6390 Govind Singh
2020-05-08 8:58 ` [PATCH 4/4] ath11k: Register mhi controller device for qca6390 Govind Singh
2020-05-11 18:03 ` Kalle Valo
2020-05-12 7:13 ` Manivannan Sadhasivam
2020-05-12 8:19 ` Kalle Valo
2020-05-12 8:24 ` Kalle Valo
2020-05-12 9:00 ` Manivannan Sadhasivam
2020-05-11 18:08 ` Kalle Valo
2020-05-15 3:28 ` Carl Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2028987516458b3145d3cd9758eafe8f@codeaurora.org \
--to=govinds@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).