From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Sujith Manoharan <c_manoha@qca.qualcomm.com>,
<linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 09/22] ath9k: Handle fatal interrupts properly
Date: Tue, 29 May 2012 18:20:57 +0530 [thread overview]
Message-ID: <20420.50737.885895.629888@gargle.gargle.HOWL> (raw)
In-Reply-To: <4FC4C47A.50006@openwrt.org>
Felix Fietkau wrote:
> Hm, good point. Maybe use u32 then. Either way, the lock in this patch
> does almost nothing to protect against race conditions, since it doesn't
> apply to other places in the code that change sc->sc_flags.
> Maybe we should change that entire thing to just use set_bit/test_bit
> instead.
That is because the locking for all the other flags has to be cleaned up.
Especially the powersave/beacon flags, and the usage of other locks
are hazy (sc_pcu_lock etc.). We can clean all of them, but I think it
will be an involved process - and the watchdog race is a crippling issue
as far as general usage is concerned. Disconnects occur in regular usage
quite frequently, breaking stress tests.
Sujith
next prev parent reply other threads:[~2012-05-29 12:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 4:02 [PATCH v2 09/22] ath9k: Handle fatal interrupts properly Sujith Manoharan
2012-05-29 12:29 ` Felix Fietkau
2012-05-29 12:36 ` Johannes Berg
2012-05-29 12:43 ` Felix Fietkau
2012-05-29 12:50 ` Sujith Manoharan [this message]
2012-06-02 11:53 ` Sujith Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20420.50737.885895.629888@gargle.gargle.HOWL \
--to=c_manoha@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).