From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: [PATCH] ath9k: fix reset work check properly
Date: Mon, 9 Jul 2012 12:14:37 +0530 [thread overview]
Message-ID: <20474.32213.21743.932687@gargle.gargle.HOWL> (raw)
In-Reply-To: <1341815640-6299-1-git-send-email-rmanohar@qca.qualcomm.com>
Rajkumar Manoharan wrote:
> Once the hw reset work is queued up and to bail out current
> execution properly, use HW_RESET bit ops instead of work_pending.
> As work_pending might return false when the queued work is in
> execution. So it is not correct to use the work utility for
> baining out.
I have one comment, though.
> diff --git a/drivers/net/wireless/ath/ath9k/beacon.c b/drivers/net/wireless/ath/ath9k/beacon.c
> index 40775da..567a655 100644
> --- a/drivers/net/wireless/ath/ath9k/beacon.c
> +++ b/drivers/net/wireless/ath/ath9k/beacon.c
> @@ -362,7 +362,7 @@ void ath_beacon_tasklet(unsigned long data)
> int slot;
> u32 bfaddr, bc = 0;
>
> - if (work_pending(&sc->hw_reset_work)) {
> + if (test_bit(SC_OP_HW_RESET, &sc->sc_flags)) {
This is not needed, since we bail out in ath_isr().
(And interrupts are re-enabled only at the end of ath9k_tasklet()).
Sujith
next prev parent reply other threads:[~2012-07-09 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 6:34 [PATCH] ath9k: fix reset work check properly Rajkumar Manoharan
2012-07-09 6:34 ` Sujith Manoharan
2012-07-09 8:57 ` Sujith Manoharan
2012-07-09 6:44 ` Sujith Manoharan [this message]
2012-07-09 7:02 ` Sujith Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20474.32213.21743.932687@gargle.gargle.HOWL \
--to=c_manoha@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox