From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: Felix Fietkau <nbd@openwrt.org>, <linux-wireless@vger.kernel.org>,
<linville@tuxdriver.com>, <rodrigue@qca.qualcomm.com>,
<c_manoha@qca.qualcomm.com>
Subject: Re: [PATCH v2 3.6] ath9k: fix interrupt storms on queued hardware reset
Date: Wed, 8 Aug 2012 20:55:03 +0530 [thread overview]
Message-ID: <20514.33999.490474.57680@gargle.gargle.HOWL> (raw)
In-Reply-To: <20120808144340.GA2041@vmraj-lnx.qualcomm.com>
Rajkumar Manoharan wrote:
> It is safer not to re-enable interrupts on FATAL errors rather than enabling
> it and then checking it on irq for bailing out. It would be better if you kill
> the interrupts on processing fatal interrupts.
I am not sure I understand.
The original issue was the race between reset-work and the ISR which resulted in
frequent disconnects when a BB-WATCHDOG interrupt occurred or TX hung, which was
fixed by introducing the SC_OP_HW_RESET flag. Later, the work_pending() race was
fixed. Still, this is a race that can happen and I think fixing it by bypassing
the ref-count maintenance and disabling interrupts is okay.
Sujith
prev parent reply other threads:[~2012-08-08 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 14:25 [PATCH v2 3.6] ath9k: fix interrupt storms on queued hardware reset Felix Fietkau
2012-08-08 14:43 ` Rajkumar Manoharan
2012-08-08 15:00 ` Felix Fietkau
2012-08-08 15:20 ` Rajkumar Manoharan
2012-08-08 15:25 ` Sujith Manoharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20514.33999.490474.57680@gargle.gargle.HOWL \
--to=c_manoha@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=rmanohar@qca.qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox