From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sg2plout10-01.prod.sin2.secureserver.net ([182.50.145.4]:33499 "HELO sg2plout10-01.prod.sin2.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751944Ab2KSPAG (ORCPT ); Mon, 19 Nov 2012 10:00:06 -0500 From: Sujith Manoharan MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Message-ID: <20650.18783.6821.78205@gargle.gargle.HOWL> (sfid-20121119_160011_381727_73392675) Date: Mon, 19 Nov 2012 20:29:43 +0530 To: Johannes Berg Cc: Sujith Manoharan , linux-wireless@vger.kernel.org Subject: Re: [RFC] mac80211: Add debugfs callbacks for station addition/removal In-Reply-To: <1353334496.18299.5.camel@jlt4.sipsolutions.net> References: <1353304116-7124-1-git-send-email-sujith@msujith.org> <1353334496.18299.5.camel@jlt4.sipsolutions.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: Johannes Berg wrote: > Can the files stay across a firmware restart or suspend/resume? I guess > with suspend/resume nothing can access them, but accessing them during > firmware restart might be ... strange? Not that I'm too worried about > that. As discussed in irc, leaving it to the drivers would be reasonable. BTW, here are few warnings that I saw when doing a suspend/resume cycle: linux-test kernel: WARNING: at /home/sujith/dev/wireless-testing/net/mac80211/chan.c:379 ieee80211_vif_release_channel+0x36/0x70 [mac80211]() linux-test kernel: Hardware name: LIFEBOOK AH531 linux-test kernel: Pid: 4139, comm: pm-suspend Tainted: G W O 3.7.0-rc5-wl-debug #31 linux-test kernel: Call Trace: linux-test kernel: [] warn_slowpath_common+0x7f/0xc0 linux-test kernel: [] warn_slowpath_null+0x1a/0x20 linux-test kernel: [] ieee80211_vif_release_channel+0x36/0x70 [mac80211] linux-test kernel: [] __ieee80211_suspend+0x45a/0xd10 [mac80211] linux-test kernel: [] ? rtnl_lock+0x17/0x20 linux-test kernel: [] ieee80211_suspend+0x1a/0x20 [mac80211] linux-test kernel: [] wiphy_suspend+0x95/0x180 [cfg80211] linux-test kernel: [] ? wiphy_resume+0x180/0x180 [cfg80211] linux-test kernel: [] legacy_suspend+0x2a/0x58 linux-test kernel: [] __device_suspend+0x1fc/0x210 linux-test kernel: [] dpm_suspend+0x68/0x240 linux-test kernel: [] dpm_suspend_start+0x57/0x60 linux-test kernel: [] suspend_devices_and_enter+0x81/0x340 linux-test kernel: [] pm_suspend+0x1f4/0x200 linux-test kernel: [] state_store+0x87/0xf0 linux-test kernel: [] kobj_attr_store+0xf/0x20 linux-test kernel: [] sysfs_write_file+0xe0/0x150 linux-test kernel: [] vfs_write+0xa8/0x180 linux-test kernel: [] sys_write+0x52/0xa0 linux-test kernel: [] system_call_fastpath+0x16/0x1b and linux-test kernel: WARNING: at /home/sujith/dev/wireless-testing/net/mac80211/ieee80211_i.h:1503 ieee80211_send_nullfunc+0xfe/0x130 [mac80211]() linux-test kernel: Hardware name: LIFEBOOK AH531 linux-test kernel: Pid: 4139, comm: pm-suspend Tainted: G W O 3.7.0-rc5-wl-debug #31 linux-test kernel: Call Trace: linux-test kernel: [] warn_slowpath_common+0x7f/0xc0 linux-test kernel: [] warn_slowpath_null+0x1a/0x20 linux-test kernel: [] ieee80211_send_nullfunc+0xfe/0x130 [mac80211] linux-test kernel: [] ? ieee80211_send_nullfunc+0x61/0x130 [mac80211] linux-test kernel: [] ? ieee80211_recalc_ps+0x1e5/0x230 [mac80211] linux-test kernel: [] ieee80211_reconfig+0x15ac/0x1c00 [mac80211] linux-test kernel: [] ieee80211_resume+0x2d/0x70 [mac80211] linux-test kernel: [] wiphy_resume+0x99/0x180 [cfg80211] linux-test kernel: [] ? index_show+0x30/0x30 [cfg80211] linux-test kernel: [] dpm_run_callback.isra.4+0x3b/0x70 linux-test kernel: [] device_resume+0xbc/0x150 linux-test kernel: [] dpm_resume+0x114/0x250 linux-test kernel: [] dpm_resume_end+0x15/0x30 linux-test kernel: [] ? acpi_suspend_begin_old+0x2d/0x2d linux-test kernel: [] suspend_devices_and_enter+0xb6/0x340 linux-test kernel: [] pm_suspend+0x1f4/0x200 linux-test kernel: [] state_store+0x87/0xf0 linux-test kernel: [] kobj_attr_store+0xf/0x20 linux-test kernel: [] sysfs_write_file+0xe0/0x150 linux-test kernel: [] vfs_write+0xa8/0x180 linux-test kernel: [] sys_write+0x52/0xa0 linux-test kernel: [] system_call_fastpath+0x16/0x1b Sujith