From: Sujith Manoharan <sujith@msujith.org>
To: Adrian Chadd <adrian@freebsd.org>
Cc: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>,
rodrigue@qca.qualcomm.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] qca-swiss-army-knife: Add support to dump AR9003 chips EEPROM
Date: Thu, 6 Dec 2012 08:25:06 +0530 [thread overview]
Message-ID: <20672.2314.800969.75984@gargle.gargle.HOWL> (raw)
In-Reply-To: <CAJ-VmonMu=98Viwk1qvR-NGrO-qBx2KYT551xaO1KjHEz4Kt3A@mail.gmail.com>
Adrian Chadd wrote:
> Just a general comment - wouldn't it be cleaner to have the PCI IDs
> and the EEPROM definitions pulled from the ath9k driver source or a
> separate header file, so you don't run the risk of having definitions
> "drift" slightly?
>
> I doubt that anyone is going to change the cal data format or the
> default templates very often (or at all!), but .. just having those
> definitions duplicated feels wrong to me.
Yes, this would be neat, we should probably be in sync with the
headers in the driver source.
Sujith
prev parent reply other threads:[~2012-12-06 2:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 9:13 [PATCH] qca-swiss-army-knife: Add support to dump AR9003 chips EEPROM Rajkumar Manoharan
2012-12-05 18:39 ` Luis R. Rodriguez
2012-12-05 20:39 ` Adrian Chadd
2012-12-06 2:55 ` Sujith Manoharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20672.2314.800969.75984@gargle.gargle.HOWL \
--to=sujith@msujith.org \
--cc=adrian@freebsd.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qca.qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox