From: Omer El Idrissi <omer.e.idrissi@gmail.com>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>, johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: move static function from header to referenced file
Date: Fri, 30 Oct 2026 14:21:46 +0100 [thread overview]
Message-ID: <2070cf87-bc38-4237-a58b-6554572a8842@gmail.com> (raw)
In-Reply-To: <b60d12eb-dad1-4482-89ca-155dfcb410b9@oss.qualcomm.com>
>> Move static function from header file to only c file it's used in.
> why? all the drv_ inlines are in driver-ops.h
>
> first rule of commit text is to describe the problem you are tying to solve.
>
> don't add unnecessary churn to the wireless code.
i moved it because multiple files include the header and when those are
compiled they don't see the tracepoint definition because the next patch
ifdef guards it under the same config that enables the only file the
static function that uses the tracepoint is called from.
this static function was only used in that file and i didn't see any
obvious reason for it's existance in that header so i moved it to the
file where it's used.
commit messages are kept in the git history. should i send a v2 with a
better commit message? or is the patch series problematic otherwise?
next prev parent reply other threads:[~2026-10-30 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 15:55 [PATCH 0/2] mac80211: hide tracepoint definition Omer El Idrissi
2026-10-17 15:55 ` [PATCH 1/2] mac80211: move static function from header to referenced file Omer El Idrissi
2026-10-30 1:31 ` Jeff Johnson
2026-10-30 13:21 ` Omer El Idrissi [this message]
2026-10-17 15:55 ` [PATCH 2/2] mac80211: hide drv_get_stats tracepoint with ifdef guard Omer El Idrissi
2026-10-24 14:31 ` [PATCH 0/2] mac80211: hide tracepoint definition Omer El Idrissi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2070cf87-bc38-4237-a58b-6554572a8842@gmail.com \
--to=omer.e.idrissi@gmail.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox