* correct way to reduce traffic needed for LED triggering
@ 2013-09-11 18:32 Oleksij Rempel
2013-09-11 19:00 ` Christian Lamparter
0 siblings, 1 reply; 2+ messages in thread
From: Oleksij Rempel @ 2013-09-11 18:32 UTC (permalink / raw)
To: linux-wireless
Hello all,
what is correct way to reduce IO needed for LED blinking? I did it with
ieee80211_queue_delayed_work(.., &priv->led-work, msecs_to_jiffird(HZ));
or are there other way to regulate it?
--
Regards,
Oleksij
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: correct way to reduce traffic needed for LED triggering
2013-09-11 18:32 correct way to reduce traffic needed for LED triggering Oleksij Rempel
@ 2013-09-11 19:00 ` Christian Lamparter
0 siblings, 0 replies; 2+ messages in thread
From: Christian Lamparter @ 2013-09-11 19:00 UTC (permalink / raw)
To: Oleksij Rempel; +Cc: linux-wireless
On Wednesday 11 September 2013 20:32:01 Oleksij Rempel wrote:
> what is correct way to reduce IO needed for LED blinking? I did it with
> ieee80211_queue_delayed_work(.., &priv->led-work, msecs_to_jiffird(HZ));
>
> or are there other way to regulate it?
Yes, you can offload some "blinking" overhead by implementing
blink_set in led_classdev (aka "priv->led_cdev").
<http://lxr.free-electrons.com/source/include/linux/leds.h#L61>
(Of course, you'll have to add the "blink" routines into
the FW. But that shouldn't be much of a problem).
If you need some inspiration: rt2x00, iwlegacy and iwlwifi
are using blink_set.
Regards,
Christian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-11 19:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11 18:32 correct way to reduce traffic needed for LED triggering Oleksij Rempel
2013-09-11 19:00 ` Christian Lamparter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).