From: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
To: Kirshenbaum Erez <erezk@wilocity.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] wil6210: set vring index for all descriptors
Date: Thu, 20 Jun 2013 16:55:44 +0300 [thread overview]
Message-ID: <2097949.LkKlZN97tx@lx-vladimir> (raw)
In-Reply-To: <1371732325-4112-1-git-send-email-erezk@wilocity.com>
On Thursday, June 20, 2013 03:45:25 PM Kirshenbaum Erez wrote:
> The vring index (MAC queue id) must be set in all TX descriptors
> otherwise HW will fail to release descriptors for a specific vring
> (disconnect or vring switch flows).
> This is normally occurs when fragmentation required, if vring index
> will not be the same for all SKB descriptors HW will fail to flush this
> MAC queue.
>
> Signed-off-by: Kirshenbaum Erez <erezk@wilocity.com>
> ---
> drivers/net/wireless/ath/wil6210/txrx.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wil6210/txrx.c b/drivers/net/wireless/ath/wil6210/txrx.c
> index e1c492b..b79ba10 100644
> --- a/drivers/net/wireless/ath/wil6210/txrx.c
> +++ b/drivers/net/wireless/ath/wil6210/txrx.c
> @@ -621,7 +621,8 @@ static struct vring *wil_find_tx_vring(struct wil6210_priv *wil,
> return NULL;
> }
>
> -static int wil_tx_desc_map(struct vring_tx_desc *d, dma_addr_t pa, u32 len)
> +static int wil_tx_desc_map(struct vring_tx_desc *d, dma_addr_t pa, u32 len,
> + int vring_index)
> {
> wil_desc_addr_set(&d->dma.addr, pa);
> d->dma.ip_length = 0;
> @@ -631,6 +632,7 @@ static int wil_tx_desc_map(struct vring_tx_desc *d, dma_addr_t pa, u32 len)
> d->dma.status = 0; /* BIT(0) should be 0 for HW_OWNED */
> d->dma.length = cpu_to_le16((u16)len);
> d->dma.d0 = 0;
Then, remove line above
> + d->dma.d0 = (vring_index << DMA_CFG_DESC_TX_0_QID_POS);
> d->mac.d[0] = 0;
> d->mac.d[1] = 0;
> d->mac.d[2] = 0;
<skip>
The rest looks fine
Thanks, Vladimir
next prev parent reply other threads:[~2013-06-20 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 12:45 [PATCH 1/2] wil6210: set vring index for all descriptors Kirshenbaum Erez
2013-06-20 13:55 ` Vladimir Kondratiev [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-23 9:59 [PATCH 0/2] wil6210: Tx path improvements Vladimir Kondratiev
2013-06-23 9:59 ` [PATCH 1/2] wil6210: set vring index for all descriptors Vladimir Kondratiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2097949.LkKlZN97tx@lx-vladimir \
--to=qca_vkondrat@qca.qualcomm.com \
--cc=erezk@wilocity.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox