From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s72.web-hosting.com ([198.187.29.22]:58351 "EHLO s72.web-hosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751206AbaIQGBG (ORCPT ); Wed, 17 Sep 2014 02:01:06 -0400 From: Sujith Manoharan MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Message-ID: <21529.9155.323515.987489@gargle.gargle.HOWL> (sfid-20140917_080117_220538_DA60F208) Date: Wed, 17 Sep 2014 11:31:39 +0530 To: "Grumbach\, Emmanuel" Cc: Johannes Berg , "linux-wireless\@vger.kernel.org" Subject: RE: [PATCH] mac80211: Call mgd_prepare_tx before deauthentication In-Reply-To: <0BA3FCBA62E2DC44AF3030971E174FB31B5230C9@hasmsx107.ger.corp.intel.com> References: <1410928422-25587-1-git-send-email-sujith@msujith.org> <21529.5141.845629.86918@gargle.gargle.HOWL> <0BA3FCBA62E2DC44AF3030971E174FB31B523034@hasmsx107.ger.corp.intel.com> <21529.8110.26388.664223@gargle.gargle.HOWL> <0BA3FCBA62E2DC44AF3030971E174FB31B5230C9@hasmsx107.ger.corp.intel.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: Grumbach, Emmanuel wrote: > I see - we also had this problem and because of this, we implemented the flush > callback that allows to wait until all the queues are empty. So mac80211 will > send the deauth, flush and only then it'd remove the VIF. This should allow > the frame to make it to the air. Note that API explicitly states that > mgd_prepare_tx is before assoc only. flush() doesn't force a context switch, no ? For example, consider a P2P-GO in freq 2412 and STA in 5180 and both are active. The current context is GO (2412) and at this time if a local deauth for the STA comes from userspace, mac80211 sends a deauth frame to the driver and calls flush(), but the context in the driver is still in channel 2412, so how will this work ? Sujith