Re: [RFC 3/4] ath9k: Fix force_channel usage for offchannel frames

[Sujith Manoharan <sujith@msujith.org>]

Sujith Manoharan wrote:
> From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
> 
> Since RoC is done before frames marked with
> IEEE80211_TX_CTL_TX_OFFCHAN are received by the driver,
> setting force_channel is useless. We will be in
> the required offchannel, so incoming frames can
> be transmitted immediately.
> 
> Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
> ---
>  drivers/net/wireless/ath/ath9k/xmit.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
> index 00931b6..4d00f59 100644
> --- a/drivers/net/wireless/ath/ath9k/xmit.c
> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
> @@ -2211,9 +2211,6 @@ int ath_tx_start(struct ieee80211_hw *hw, struct sk_buff *skb,
>  	if (vif)
>  		avp = (void *)vif->drv_priv;
>  
> -	if (info->flags & IEEE80211_TX_CTL_TX_OFFCHAN)
> -		txctl->force_channel = true;
> -
>  	ret = ath_tx_prepare(hw, skb, txctl);
>  	if (ret)
>  	    return ret;

This breaks things, so this patch can be dropped.

Sujith