From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] cfg80211: add support to configure HE MCS for beacon rate
Date: Fri, 16 Oct 2020 12:17:41 -0700 [thread overview]
Message-ID: <21941d6526fa00b9f8e0787537b963b3@codeaurora.org> (raw)
In-Reply-To: <7b0080517b301ccd32d03b25b2f16663238959df.camel@sipsolutions.net>
On 2020-10-08 02:09, Johannes Berg wrote:
> On Thu, 2020-10-08 at 11:06 +0200, Johannes Berg wrote:
>> On Sat, 2020-10-03 at 14:57 -0700, Rajkumar Manoharan wrote:
>> > This allows an option to configure a single HE MCS beacon tx rate.
>> >
>> > Signed-off-by: Rajkumar Manoharan <rmanohar@codeaurora.org>
>> > ---
>> > v2: clear mcs ratemask when beacon tx rate is not set.
>>
>> I can't believe I didn't realize this before, but ...
>
> Never mind that comment ... it wasn't there before, I was confused :)
>
No worries. :)
>> I mean, why not just skip the
>>
>> /* Default to all rates enabled */
>> for (i = 0; i < NUM_NL80211_BANDS; i++) {
>> [...]
>> }
>>
>> code? Right now you're first setting it, and then clearing it again
>> when
>> is_beacon_tx_rate is set ...
>>
>>
>> I'd prefer a "default_all_enabled" parameter, and then call the above
>> loop conditionally on it (perhaps moving it to a separate function to
>> not have all the deep indentation to worry about).
>
> And maybe that should be a separate patch.
>
Neat.. Will split the patch and send a new series.
-Rajkumar
prev parent reply other threads:[~2020-10-16 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 21:57 [PATCH v2] cfg80211: add support to configure HE MCS for beacon rate Rajkumar Manoharan
2020-10-08 9:06 ` Johannes Berg
2020-10-08 9:09 ` Johannes Berg
2020-10-16 19:17 ` Rajkumar Manoharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21941d6526fa00b9f8e0787537b963b3@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).