From: Florian Fainelli <florian@openwrt.org>
To: Arend van Spriel <arend@broadcom.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Linux Wireless List <linux-wireless@vger.kernel.org>,
Hante Meuleman <meuleman@broadcom.com>
Subject: Re: [PATCH 07/10] brcmfmac: Fix big endian host configuration data.
Date: Mon, 10 Sep 2012 18:38:21 +0200 [thread overview]
Message-ID: <2217272.VoFA81WqWx@flexo> (raw)
In-Reply-To: <1347283018-24223-8-git-send-email-arend@broadcom.com>
On Monday 10 September 2012 15:16:55 Arend van Spriel wrote:
> From: Hante Meuleman <meuleman@broadcom.com>
>
> Fixes big endian host configuration parameters.
>
> Reviewed-by: Arend Van Spriel <arend@broadcom.com>
> Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
This one too looks like a stable candidate.
> ---
> .../net/wireless/brcm80211/brcmfmac/dhd_common.c | 26
++++++++++++--------
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c
b/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c
> index 2621dd3..6f70953 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c
> @@ -764,8 +764,11 @@ static void brcmf_c_arp_offload_set(struct brcmf_pub
*drvr, int arp_mode)
> {
> char iovbuf[32];
> int retcode;
> + __le32 arp_mode_le;
>
> - brcmf_c_mkiovar("arp_ol", (char *)&arp_mode, 4, iovbuf, sizeof(iovbuf));
> + arp_mode_le = cpu_to_le32(arp_mode);
> + brcmf_c_mkiovar("arp_ol", (char *)&arp_mode_le, 4, iovbuf,
> + sizeof(iovbuf));
> retcode = brcmf_proto_cdc_set_dcmd(drvr, 0, BRCMF_C_SET_VAR,
> iovbuf, sizeof(iovbuf));
> retcode = retcode >= 0 ? 0 : retcode;
> @@ -781,8 +784,11 @@ static void brcmf_c_arp_offload_enable(struct brcmf_pub
*drvr, int arp_enable)
> {
> char iovbuf[32];
> int retcode;
> + __le32 arp_enable_le;
>
> - brcmf_c_mkiovar("arpoe", (char *)&arp_enable, 4,
> + arp_enable_le = cpu_to_le32(arp_enable);
> +
> + brcmf_c_mkiovar("arpoe", (char *)&arp_enable_le, 4,
> iovbuf, sizeof(iovbuf));
> retcode = brcmf_proto_cdc_set_dcmd(drvr, 0, BRCMF_C_SET_VAR,
> iovbuf, sizeof(iovbuf));
> @@ -800,10 +806,10 @@ int brcmf_c_preinit_dcmds(struct brcmf_pub *drvr)
> char iovbuf[BRCMF_EVENTING_MASK_LEN + 12]; /* Room for
> "event_msgs" + '\0' + bitvec */
> char buf[128], *ptr;
> - u32 roaming = 1;
> - uint bcn_timeout = 3;
> - int scan_assoc_time = 40;
> - int scan_unassoc_time = 40;
> + __le32 roaming_le = cpu_to_le32(1);
> + __le32 bcn_timeout_le = cpu_to_le32(3);
> + __le32 scan_assoc_time_le = cpu_to_le32(40);
> + __le32 scan_unassoc_time_le = cpu_to_le32(40);
> int i;
> struct brcmf_bus_dcmd *cmdlst;
> struct list_head *cur, *q;
> @@ -829,14 +835,14 @@ int brcmf_c_preinit_dcmds(struct brcmf_pub *drvr)
>
> /* Setup timeout if Beacons are lost and roam is off to report
> link down */
> - brcmf_c_mkiovar("bcn_timeout", (char *)&bcn_timeout, 4, iovbuf,
> + brcmf_c_mkiovar("bcn_timeout", (char *)&bcn_timeout_le, 4, iovbuf,
> sizeof(iovbuf));
> brcmf_proto_cdc_set_dcmd(drvr, 0, BRCMF_C_SET_VAR, iovbuf,
> sizeof(iovbuf));
>
> /* Enable/Disable build-in roaming to allowed ext supplicant to take
> of romaing */
> - brcmf_c_mkiovar("roam_off", (char *)&roaming, 4,
> + brcmf_c_mkiovar("roam_off", (char *)&roaming_le, 4,
> iovbuf, sizeof(iovbuf));
> brcmf_proto_cdc_set_dcmd(drvr, 0, BRCMF_C_SET_VAR, iovbuf,
> sizeof(iovbuf));
> @@ -848,9 +854,9 @@ int brcmf_c_preinit_dcmds(struct brcmf_pub *drvr)
> sizeof(iovbuf));
>
> brcmf_proto_cdc_set_dcmd(drvr, 0, BRCMF_C_SET_SCAN_CHANNEL_TIME,
> - (char *)&scan_assoc_time, sizeof(scan_assoc_time));
> + (char *)&scan_assoc_time_le, sizeof(scan_assoc_time_le));
> brcmf_proto_cdc_set_dcmd(drvr, 0, BRCMF_C_SET_SCAN_UNASSOC_TIME,
> - (char *)&scan_unassoc_time, sizeof(scan_unassoc_time));
> + (char *)&scan_unassoc_time_le, sizeof(scan_unassoc_time_le));
>
> /* Set and enable ARP offload feature */
> brcmf_c_arp_offload_set(drvr, BRCMF_ARPOL_MODE);
> --
> 1.7.9.5
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-10 16:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 13:16 [PATCH 00/10] brcmfmac: transmit flow control and e-scan support Arend van Spriel
2012-09-10 13:16 ` [PATCH 01/10] brcmfmac: Stop all net if queues on tx flow halt Arend van Spriel
2012-09-10 13:16 ` [PATCH 02/10] brcmfmac: Add extra data support to firmware event queueing Arend van Spriel
2012-09-10 13:16 ` [PATCH 03/10] brcmfmac: Fix extra data support handling Arend van Spriel
2012-09-10 16:37 ` Florian Fainelli
2012-09-10 13:16 ` [PATCH 04/10] brcmfmac: Add tx flow control on net if queue for USB Arend van Spriel
2012-09-10 13:16 ` [PATCH 05/10] brcmfmac: Clean up scan related code Arend van Spriel
2012-09-10 13:16 ` [PATCH 06/10] brcmfmac: fix big endian bug in i-scan Arend van Spriel
2012-09-10 16:37 ` Florian Fainelli
2012-09-10 13:16 ` [PATCH 07/10] brcmfmac: Fix big endian host configuration data Arend van Spriel
2012-09-10 16:38 ` Florian Fainelli [this message]
2012-09-10 13:16 ` [PATCH 08/10] brcmfmac: refill buffers on rx protocol error Arend van Spriel
2012-09-10 13:16 ` [PATCH 09/10] brcmfmac: avoid using local usb data Arend van Spriel
2012-09-10 13:16 ` [PATCH 10/10] brcmfmac: add e-scan support Arend van Spriel
2012-09-10 20:59 ` [PATCH 00/10] brcmfmac: transmit flow control and " Arend van Spriel
2012-09-11 18:49 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2217272.VoFA81WqWx@flexo \
--to=florian@openwrt.org \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=meuleman@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).