From: "Carl J. Richell" <carl@system76.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: rtlwifi: rtl8192ce: LED initialization
Date: Tue, 19 Apr 2011 15:18:18 -0600 (MDT) [thread overview]
Message-ID: <22202847.17614.1303247898049.JavaMail.root@mail> (raw)
In-Reply-To: <4DADFAA0.7010205@lwfinger.net>
----- Original Message -----
> On 04/19/2011 02:57 PM, Carl J. Richell wrote:
> > Hi wireless developers,
> >
> > The patch at the following link fixes the wireless LED on rtl8192ce
> > devices.
> >
> > http://marc.info/?l=linux-wireless&m=130247823800466&w=2
> >
> > However, there is the following Error when compiling against 2.6.38
> > in Ubuntu natty:
> >
> > "
> > drivers/net/wireless/rtlwifi/rtl8192ce/led.c: In function
> > ‘_rtl92ce_init_led’:
> > drivers/net/wireless/rtlwifi/rtl8192ce/led.c:40:6: error: ‘struct
> > rtl_led’ has no member named ‘ledon’
> > make[5]: *** [drivers/net/wireless/rtlwifi/rtl8192ce/led.o] Error 1
> > "
> >
> > The driver compiles correctly and the LED works after commenting out
> > the offending line:
> >
> > wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/led.c
> >
> > static void _rtl92ce_init_led(struct ieee80211_hw *hw,
> > struct rtl_led *pled, enum rtl_led_pin ledpin)
> > {
> > pled->hw = hw;
> > pled->ledpin = ledpin;
> > /* pled->ledon = false; */
> > }
> >
> > Is this an appropriate fix?
>
> The patch was made for 2.6.39.
>
> For 2.6.38, the routine _rtl92ce_init_led() does not exist, thus some
> of the
> other changes in rtl8192ce from .38 to .39 have been put into the
> driver, but
> not all. Your change should be OK.
>
Thank you, Larry. Much appreciated!
Carl
prev parent reply other threads:[~2011-04-19 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <30703261.17529.1303241985428.JavaMail.root@mail>
2011-04-19 19:57 ` rtlwifi: rtl8192ce: LED initialization Carl J. Richell
2011-04-19 21:12 ` Larry Finger
2011-04-19 21:18 ` Carl J. Richell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22202847.17614.1303247898049.JavaMail.root@mail \
--to=carl@system76.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).