* rtlwifi: rtl8192ce: LED initialization
[not found] <30703261.17529.1303241985428.JavaMail.root@mail>
@ 2011-04-19 19:57 ` Carl J. Richell
2011-04-19 21:12 ` Larry Finger
0 siblings, 1 reply; 3+ messages in thread
From: Carl J. Richell @ 2011-04-19 19:57 UTC (permalink / raw)
To: linux-wireless
Hi wireless developers,
The patch at the following link fixes the wireless LED on rtl8192ce devices.
http://marc.info/?l=linux-wireless&m=130247823800466&w=2
However, there is the following Error when compiling against 2.6.38 in Ubuntu natty:
"
drivers/net/wireless/rtlwifi/rtl8192ce/led.c: In function ‘_rtl92ce_init_led’:
drivers/net/wireless/rtlwifi/rtl8192ce/led.c:40:6: error: ‘struct rtl_led’ has no member named ‘ledon’
make[5]: *** [drivers/net/wireless/rtlwifi/rtl8192ce/led.o] Error 1
"
The driver compiles correctly and the LED works after commenting out the offending line:
wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/led.c
static void _rtl92ce_init_led(struct ieee80211_hw *hw,
struct rtl_led *pled, enum rtl_led_pin ledpin)
{
pled->hw = hw;
pled->ledpin = ledpin;
/* pled->ledon = false; */
}
Is this an appropriate fix?
Best Regards,
Carl Richell
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: rtlwifi: rtl8192ce: LED initialization
2011-04-19 19:57 ` rtlwifi: rtl8192ce: LED initialization Carl J. Richell
@ 2011-04-19 21:12 ` Larry Finger
2011-04-19 21:18 ` Carl J. Richell
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2011-04-19 21:12 UTC (permalink / raw)
To: Carl J. Richell; +Cc: linux-wireless
On 04/19/2011 02:57 PM, Carl J. Richell wrote:
> Hi wireless developers,
>
> The patch at the following link fixes the wireless LED on rtl8192ce devices.
>
> http://marc.info/?l=linux-wireless&m=130247823800466&w=2
>
> However, there is the following Error when compiling against 2.6.38 in Ubuntu natty:
>
> "
> drivers/net/wireless/rtlwifi/rtl8192ce/led.c: In function ‘_rtl92ce_init_led’:
> drivers/net/wireless/rtlwifi/rtl8192ce/led.c:40:6: error: ‘struct rtl_led’ has no member named ‘ledon’
> make[5]: *** [drivers/net/wireless/rtlwifi/rtl8192ce/led.o] Error 1
> "
>
> The driver compiles correctly and the LED works after commenting out the offending line:
>
> wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/led.c
>
> static void _rtl92ce_init_led(struct ieee80211_hw *hw,
> struct rtl_led *pled, enum rtl_led_pin ledpin)
> {
> pled->hw = hw;
> pled->ledpin = ledpin;
> /* pled->ledon = false; */
> }
>
> Is this an appropriate fix?
The patch was made for 2.6.39.
For 2.6.38, the routine _rtl92ce_init_led() does not exist, thus some of the
other changes in rtl8192ce from .38 to .39 have been put into the driver, but
not all. Your change should be OK.
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: rtlwifi: rtl8192ce: LED initialization
2011-04-19 21:12 ` Larry Finger
@ 2011-04-19 21:18 ` Carl J. Richell
0 siblings, 0 replies; 3+ messages in thread
From: Carl J. Richell @ 2011-04-19 21:18 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless
----- Original Message -----
> On 04/19/2011 02:57 PM, Carl J. Richell wrote:
> > Hi wireless developers,
> >
> > The patch at the following link fixes the wireless LED on rtl8192ce
> > devices.
> >
> > http://marc.info/?l=linux-wireless&m=130247823800466&w=2
> >
> > However, there is the following Error when compiling against 2.6.38
> > in Ubuntu natty:
> >
> > "
> > drivers/net/wireless/rtlwifi/rtl8192ce/led.c: In function
> > ‘_rtl92ce_init_led’:
> > drivers/net/wireless/rtlwifi/rtl8192ce/led.c:40:6: error: ‘struct
> > rtl_led’ has no member named ‘ledon’
> > make[5]: *** [drivers/net/wireless/rtlwifi/rtl8192ce/led.o] Error 1
> > "
> >
> > The driver compiles correctly and the LED works after commenting out
> > the offending line:
> >
> > wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/led.c
> >
> > static void _rtl92ce_init_led(struct ieee80211_hw *hw,
> > struct rtl_led *pled, enum rtl_led_pin ledpin)
> > {
> > pled->hw = hw;
> > pled->ledpin = ledpin;
> > /* pled->ledon = false; */
> > }
> >
> > Is this an appropriate fix?
>
> The patch was made for 2.6.39.
>
> For 2.6.38, the routine _rtl92ce_init_led() does not exist, thus some
> of the
> other changes in rtl8192ce from .38 to .39 have been put into the
> driver, but
> not all. Your change should be OK.
>
Thank you, Larry. Much appreciated!
Carl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-19 21:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <30703261.17529.1303241985428.JavaMail.root@mail>
2011-04-19 19:57 ` rtlwifi: rtl8192ce: LED initialization Carl J. Richell
2011-04-19 21:12 ` Larry Finger
2011-04-19 21:18 ` Carl J. Richell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).