From: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: GFP flags for cfg80211_rx_mgmt
Date: Sun, 10 Aug 2014 01:13:19 -0700 [thread overview]
Message-ID: <2261364.hhWvLn60TS@lx-wigig-72> (raw)
In-Reply-To: <1405935461.32255.3.camel@jlt4.sipsolutions.net>
On Monday, July 21, 2014 11:37:41 AM Johannes Berg wrote:
> On Sun, 2014-07-13 at 08:02 -0700, Vladimir Kondratiev wrote:
> > Hi,
> >
> > In the cfg80211_rx_mgmt(), there is parameter 'gfp_t gfp' that is
> > passed to the nl80211_send_mgmt() and then to alloc_skb().
> > In fact, nl80211_send_mgmt() called under spinlock, so
> > one can't use GFP_KERNEL. However, documentation for
> > cfg80211_rx_mgmt does not restrict GFP flags.
> >
> > I suggest to document this, and enforce in some way (WARN_ONCE?),
> > or just remove this parameter - everywhere in the kernel
> > GFP_ATOMIC is used.
>
> I say just remove it, want to send a patch?
>
> johannes
>
Yes, I will. Sorry for delay, was out (climbing some 7000m+ peak :-) )
prev parent reply other threads:[~2014-08-10 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-13 15:02 GFP flags for cfg80211_rx_mgmt Vladimir Kondratiev
2014-07-21 9:37 ` Johannes Berg
2014-08-10 8:13 ` Vladimir Kondratiev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2261364.hhWvLn60TS@lx-wigig-72 \
--to=qca_vkondrat@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox