Re: Driver for rtw8723ds

Larry Finger
2023-05-04T20:55:17Z

On 5/4/23 15:13, Jernej Škrabec wrote:
> Dne četrtek, 04. maj 2023 ob 21:45:31 CEST je Martin Blumenstingl napisal(a):
>> Hi Larry,
>>
>> On Thu, May 4, 2023 at 9:25 PM Larry Finger <Larry.Finger@lwfinger.net>
>> wrote: [...]
>>
>>>> Can you ask that user to test following commits?
>>>> https://github.com/xdarklight/linux/commit/
>>>> 3866a7a3702f7f24557f2c065b7d4088f7027466
>>>> https://github.com/xdarklight/linux/commit/
>>>> 66fd078556a6bf246337270b2e91d73c079fce2d
>>>>
>>>> Patches are trivial, but some testing needs to be done to confirm the
>>>> driver actually works as intended.
>>>
>>> Jernej,
>>>
>>> The user needs the rtw8723ds driver - the SDIO equivalent of rtw8723du.c
>>> that is used by the USB device. The riscv changes may be needed, but we
>>> are not quite that far yet.
>>
>> Strange, can you please elaborate what you are seeing in terms of riscv?
>> The two commits that Jernej shared are for an update to rtw8723d.c [0]
>> and the addition of a rtw8723ds driver [1]. None of these mentions
>> riscv (at least that's what my tired eyes are seeing today).
>>
>>
>> Best regards,
>> Martin
>>
>>
>> [0]
>> https://github.com/xdarklight/linux/commit/3866a7a3702f7f24557f2c065b7d4088
>> f7027466 [1]
>> https://github.com/xdarklight/linux/commit/66fd078556a6bf246337270b2e91d73c
>> 079fce2d
>
> Problem is that my e-mail client split commit links in two parts. If you
> combine hashes with rest it opens correct commits. Currently, it opens head of
> your master branch, which is by chance risc-v merge commit.

After I compared the links that Martin sent with yours, I figured out the problem.

I downloaded the patches and applied them to my rtw88 repo. The user that wanted
rtw8723ds support has been notified. We will see how it goes.

Thanks,

Larry