Re: [PATCH v3 12/13] wifi: ath12k: Read board id to support split-PHY QCN9274

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]

On Monday, 29 January 2024 07:57:23 CET Raj Kumar Bhagat wrote:
> diff --git a/drivers/net/wireless/ath/ath12k/fw.c b/drivers/net/wireless/ath/ath12k/fw.c
> index fbcf40c97792..5be4b2d4a19d 100644
> --- a/drivers/net/wireless/ath/ath12k/fw.c
> +++ b/drivers/net/wireless/ath/ath12k/fw.c
> @@ -119,6 +119,13 @@ static int ath12k_fw_request_firmware_api_n(struct ath12k_base *ab,
[...]
> +		case ATH12K_FW_IE_AMSS_DUALMAC_IMAGE:
> +			ath12k_dbg(ab, ATH12K_DBG_BOOT,
> +				   "found dualmac fw image ie (%zd B)\n",
> +				   ie_len);
> +			ab->fw.amss_dualmac_data = data;
> +			ab->fw.amss_dualmac_len = ie_len;
> +			break;
>  		default:
>  			ath12k_warn(ab, "Unknown FW IE: %u\n", ie_id);
>  			break;

> @@ -371,16 +375,43 @@ int ath12k_mhi_register(struct ath12k_pci *ab_pci)
[...]
> +	if (dualmac) {
> +		if (ab->fw.amss_dualmac_data && ab->fw.amss_dualmac_len > 0) {
> +			/* use MHI firmware file from firmware-N.bin */
> +			mhi_ctrl->fw_data = ab->fw.amss_dualmac_data;
> +			mhi_ctrl->fw_sz = ab->fw.amss_dualmac_len;
> +		} else {
> +			ath12k_warn(ab, "dualmac firmware IE not present in firmware-N.bin\n");
> +			ret = -ENOENT;
> +			goto free_controller;
> +		}

I saw this now already multiple times that the source code was referencing the 
firmware-N.bin (like we had with ath10k). But they aren't published anywhere. 
I can't find a single one at:

* https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ath11k
* https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ath12k
* https://github.com/kvalo/ath11k-firmware
* https://github.com/quic/upstream-wifi-fw

So I find it odd that the new code now seems to depend on it without actually 
providing these files anywhere.

Might be good to have these soon in linux-firmware.git.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]