public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Achleitner <flo@fopen.at>
To: linux-wireless@vger.kernel.org
Cc: Amitkumar Karwar <akarwar@marvell.com>,
	Avinash Patil <patila@marvell.com>,
	Maithili Hinge <maithili@marvell.com>
Subject: [PATCH] mwifiex: Trigger a card reset on "DNLD_CMD: host to card failed".
Date: Thu, 16 Apr 2015 11:14:48 +0200	[thread overview]
Message-ID: <2350188.9S0zOEq5AR@r90b40zn> (raw)
In-Reply-To: <3169170.GKjfvNuGRf@r90b40zn>

Whenever this problem occurs, the driver can not continue. Thus,
trigger a card reset to restart the module firmware. Other firmware
communication issues are resolved by this last resort.
Also dump registers, to eventually allow some diagnostics.

Signed-off-by: Florian Achleitner <flo@fopen.at>
---

This works well at least for us.

 drivers/net/wireless/mwifiex/cmdevt.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/wireless/mwifiex/cmdevt.c b/drivers/net/wireless/mwifiex/cmdevt.c
index c5a14ff..410f4f2 100644
--- a/drivers/net/wireless/mwifiex/cmdevt.c
+++ b/drivers/net/wireless/mwifiex/cmdevt.c
@@ -233,6 +233,12 @@ static int mwifiex_dnld_cmd_to_fw(struct mwifiex_private *priv,
                spin_unlock_irqrestore(&adapter->mwifiex_cmd_lock, flags);
 
                adapter->dbg.num_cmd_host_to_card_failure++;
+
+               if (adapter->if_ops.fw_dump)
+                       adapter->if_ops.fw_dump(adapter);
+
+               if (adapter->if_ops.card_reset)
+                       adapter->if_ops.card_reset(adapter);
                return -1;
        }
 
-- 
2.1.0



  reply	other threads:[~2015-04-16  9:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-16  9:10 [RFC/PATCH] mwifiex: Driver - Firmware Glitches Florian Achleitner
2015-04-16  9:14 ` Florian Achleitner [this message]
2015-05-09 13:35   ` [PATCH] mwifiex: Trigger a card reset on "DNLD_CMD: host to card failed" Kalle Valo
2015-05-09 16:18     ` Florian Achleitner
2015-05-11  6:35       ` Kalle Valo
2015-04-16  9:30 ` [RFC/PATCH] mwifiex: Driver - Firmware Glitches Amitkumar Karwar
2015-04-16 10:34   ` Florian Achleitner
2015-04-16 11:21     ` Amitkumar Karwar
2015-04-16 13:19       ` Florian Achleitner
2015-04-17  8:29         ` Florian Achleitner
2015-04-17  9:45           ` Amitkumar Karwar
2015-04-23  8:33             ` Florian Achleitner
2015-04-23  8:43               ` James Cameron
2015-04-23  9:48                 ` Avinash Patil
2015-04-16 10:19 ` James Cameron
2015-04-16 10:43   ` Florian Achleitner
2015-04-16 11:11     ` Avinash Patil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2350188.9S0zOEq5AR@r90b40zn \
    --to=flo@fopen.at \
    --cc=akarwar@marvell.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=maithili@marvell.com \
    --cc=patila@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox