From: Ryder Lee <Ryder.Lee@mediatek.com>
To: "krzk@kernel.org" <krzk@kernel.org>
Cc: "robh@kernel.org" <robh@kernel.org>,
"nbd@nbd.name" <nbd@nbd.name>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v7 2/3] dt-bindings: net: wireless: mt76: add more PCI devices
Date: Tue, 17 Feb 2026 12:59:50 +0000 [thread overview]
Message-ID: <23f43fb875ca41a945caceba5c9fcf05331afd58.camel@mediatek.com> (raw)
In-Reply-To: <20260217-lavender-dove-from-tartarus-fca40c@quoll>
On Tue, 2026-02-17 at 08:48 +0100, Krzysztof Kozlowski wrote:
> On Mon, Feb 16, 2026 at 08:01:15AM -0800, Ryder Lee wrote:
> > This adds support for mt7915/mt7916/mt7990/mt7992/mt7996 PCI
> > devices.
>
> No, it does not add any support. I asked you to provide rationale why
> this is needed.
>
> Also, read submitting patches finally - it is not "This adds...".
Are you referring to this - Describe your changes in imperative mood...
So, what would you like me to describe this change? what about this
"Add platform IDs for known devices"?
>
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > ---
> > v7: add missing dts mailing list and maintainers
>
> No, you still did not bother to Cc maintainers. I gave you detailed
> instruction which you just ignored.
>
> Best regards,
> Krzysztof
>
Oh, I used to do it this way. But aren’t you all on the devicetree
mailing list?
I did notice that running get_maintainer added some more people.
I’ll include all dts maintainers as well.
Ryder
next prev parent reply other threads:[~2026-02-17 13:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 4:47 [PATCH v6 1/3] wifi: mt76: fix backoff fields and max_power calculation Ryder Lee
2026-02-16 4:47 ` [PATCH v6 2/3] dt-bindings: net: wireless: mt76: add more PCI devices Ryder Lee
2026-02-16 7:30 ` Krzysztof Kozlowski
2026-02-16 16:01 ` [PATCH v7 " Ryder Lee
2026-02-17 7:48 ` Krzysztof Kozlowski
2026-02-17 12:59 ` Ryder Lee [this message]
2026-02-17 13:23 ` Krzysztof Kozlowski
2026-02-17 13:51 ` Ryder Lee
2026-02-19 0:30 ` [PATCH v8 2/3] dt-bindings: net: wireless: mt76: add mt79 " Ryder Lee
2026-02-16 4:47 ` [PATCH v6 3/3] dt-bindings: net: wireless: mt76: clarify backoff limit usage Ryder Lee
2026-02-16 16:01 ` [PATCH v7 " Ryder Lee
2026-02-19 0:30 ` [PATCH v8 " Ryder Lee
2026-02-16 16:01 ` [PATCH v7 1/3] wifi: mt76: fix backoff fields and max_power calculation Ryder Lee
2026-02-19 0:30 ` [PATCH v8 " Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23f43fb875ca41a945caceba5c9fcf05331afd58.camel@mediatek.com \
--to=ryder.lee@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox