From: "Guy Cohen" <guy.cohen@intel.com>
To: "Johannes Berg" <johannes@sipsolutions.net>,
"Jouni Malinen" <j@w1.fi>,
linux-wireless@vger.kernel.org
Subject: WMM QoS classification with local bridging (bridge_packets=1)
Date: Wed, 9 Jan 2008 15:03:49 +0200 [thread overview]
Message-ID: <247d6d340801090503k289902afwd9fc22dbb4a1e70b@mail.gmail.com> (raw)
Hi,
I'm running in AP mode with 4956 and I see that frames transmitted
from one client through the AP to a second client will not have the
correct TID set in the QoS header after being forwarded from the AP.
At the end of ieee80211_deliver_skb there is this code that redirects
rx frames sent to local stations back to the wireless driver:
if (xmit_skb) {
/* send to wireless media */
xmit_skb->protocol = __constant_htons(ETH_P_802_3);
skb_reset_network_header(xmit_skb);
skb_reset_mac_header(xmit_skb);
dev_queue_xmit(xmit_skb);
}
Then in classify_1d:
if (skb->protocol != __constant_htons(ETH_P_IP) ||
skb->len < offset + sizeof(*ip))
return 0;
The thing is that the protocol is set to ETH_P_802_3 and not IP...
What do you think is the right way to fix this? Parse the frame in
deliver_skb and set the protocol to be IP (when IP frame), or leave
that as is and in classify_1d parse the frame instead of testing the
protocol field?
I'm running with a slightly older version of mac, but I think it is
the same behavior in wireless-dev 2.6 latest sources.
Thanks,
Guy.
next reply other threads:[~2008-01-09 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 13:03 Guy Cohen [this message]
2008-01-09 23:58 ` WMM QoS classification with local bridging (bridge_packets=1) Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=247d6d340801090503k289902afwd9fc22dbb4a1e70b@mail.gmail.com \
--to=guy.cohen@intel.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox