From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Luca Weiss <luca.weiss@fairphone.com>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexander Koskovich <AKoskovich@pm.me>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
Rocky Liao <quic_rjliao@quicinc.com>,
Johannes Berg <johannes@sipsolutions.net>,
Jeff Johnson <jjohnson@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-bluetooth@vger.kernel.org, linux-wireless@vger.kernel.org,
ath11k@lists.infradead.org
Subject: Re: [PATCH v2 7/7] arm64: dts: qcom: milos-fairphone-fp6: Enable WiFi
Date: Tue, 7 Apr 2026 15:16:00 +0200 [thread overview]
Message-ID: <2514523f-a43f-4470-a69b-3d5175d10385@oss.qualcomm.com> (raw)
In-Reply-To: <4fbs4arx6sez6fffy75ctmzecfvitr6aocau3cczlr2ps2ptld@v7wpa2irsihl>
On 4/3/26 9:35 PM, Dmitry Baryshkov wrote:
> On Fri, Apr 03, 2026 at 03:52:53PM +0200, Luca Weiss wrote:
>> Configure and enable the WiFi node, and add the required pinctrl to
>> provide the sleep clock from the PMK8550 (PMK7635) to WCN6755.
>>
>> Thanks to Alexander Koskovich for helping with the bringup, adding
>> the missing pinctrl to make the WPSS stop crashing.
>>
>> Link: https://lore.kernel.org/linux-arm-msm/DBF7OWAWQ94M.FSCP4DPF8ZJY@fairphone.com/
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> ---
>> arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 19 ++++++++++++++++++-
>> 1 file changed, 18 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> index db72418b7195..d8ac495ca7c8 100644
>> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> @@ -242,7 +242,7 @@ wcn6750-pmu {
>>
>> clocks = <&rpmhcc RPMH_RF_CLK1>;
>>
>> - pinctrl-0 = <&bluetooth_enable_default>;
>> + pinctrl-0 = <&bluetooth_enable_default>, <&pmk8550_sleep_clk_default>;
>> pinctrl-names = "default";
>>
>> regulators {
>> @@ -766,6 +766,17 @@ &pmiv0104_eusb2_repeater {
>> qcom,tune-usb2-preem = /bits/ 8 <0x6>;
>> };
>>
>> +&pmk8550_gpios {
>> + pmk8550_sleep_clk_default: sleep-clk-default-state {
>> + pins = "gpio5";
>> + function = "func1";
>> + input-disable;
>> + output-enable;
>
> Hmm, if it's a sleep_clk, should it not be handled via the power
> sequencer?
If you mean that it may be needed to toggle it with specific timings,
possibly.. seems that WCN6855 has a "xo-clk" GPIO defined. I requested
access to some docs that I think should have the answer, hopefully should
get it soon.
Or maybe +Jeff/Baochen could answer faster?
Konrad
next prev parent reply other threads:[~2026-04-07 13:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 13:52 [PATCH v2 0/7] Enable Bluetooth and WiFi on Fairphone (Gen. 6) Luca Weiss
2026-04-03 13:52 ` [PATCH v2 1/7] regulator: dt-bindings: qcom,qca6390-pmu: Document WCN6755 PMU Luca Weiss
2026-04-04 10:57 ` Krzysztof Kozlowski
2026-04-03 13:52 ` [PATCH v2 2/7] dt-bindings: bluetooth: qcom,wcn6750-bt: Document WCN6755 Bluetooth Luca Weiss
2026-04-04 10:58 ` Krzysztof Kozlowski
2026-04-03 13:52 ` [PATCH v2 3/7] dt-bindings: net: wireless: ath11k: Document WCN6755 WiFi Luca Weiss
2026-04-04 11:03 ` Krzysztof Kozlowski
2026-04-05 22:28 ` Jeff Johnson
2026-04-03 13:52 ` [PATCH v2 4/7] arm64: dts: qcom: milos: Split up uart11 pinctrl Luca Weiss
2026-04-03 19:32 ` Dmitry Baryshkov
2026-04-07 13:07 ` Konrad Dybcio
2026-04-03 13:52 ` [PATCH v2 5/7] arm64: dts: qcom: milos: Add WCN6755 WiFi node Luca Weiss
2026-04-03 19:33 ` Dmitry Baryshkov
2026-04-07 9:35 ` Konrad Dybcio
2026-04-03 13:52 ` [PATCH v2 6/7] arm64: dts: qcom: milos-fairphone-fp6: Enable Bluetooth Luca Weiss
2026-04-03 19:33 ` Dmitry Baryshkov
2026-04-07 13:10 ` Konrad Dybcio
2026-04-03 13:52 ` [PATCH v2 7/7] arm64: dts: qcom: milos-fairphone-fp6: Enable WiFi Luca Weiss
2026-04-03 19:35 ` Dmitry Baryshkov
2026-04-07 13:16 ` Konrad Dybcio [this message]
2026-04-06 13:17 ` (subset) [PATCH v2 0/7] Enable Bluetooth and WiFi on Fairphone (Gen. 6) Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2514523f-a43f-4470-a69b-3d5175d10385@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=AKoskovich@pm.me \
--cc=andersson@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=baochen.qiang@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=phone-devel@vger.kernel.org \
--cc=quic_bgodavar@quicinc.com \
--cc=quic_rjliao@quicinc.com \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox