From: Wojciech Dubowik <dubowoj@neratec.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, nbd@openwrt.org,
ath5k-devel@lists.ath5k.org, mickflemm@gmail.com
Subject: [PATCH v7 0/9] ath5k: Add AHB support
Date: Thu, 2 Dec 2010 10:26:46 +0100 (CET) [thread overview]
Message-ID: <25197466.1341291282005411.JavaMail.wlan@CHBU500181> (raw)
In-Reply-To: <1193716.1141291281829918.JavaMail.wlan@CHBU500181>
This series of patches implements AHB bus support for ath5k driver.
General comments for AHB bus support in ath5k:
* original patches came from Felix Fetikau. I have just made them working
on latest wireless testing.
* tried with access point functionality with WPA2 and without encryption
* tested on AR5312 and AR2313 for AHB and AR5414 and AR5212 for PCI
* tested with 2.4GHz and 5GHz band. It seems that some older chipsets
including AR5312 need tx descriptor byteswap on big endian systems in
software. I can observe that beacons all auto generated frames are
sent but software generated frames not. AR2313 doesn't need
it and both 11a and 11g seem functional. In madwifi-project, these
were platfroms which specify AH_NEED_DESC_SWAP. Second radio on
AR5312 seems to work even if byteswapping is set in hardware and not
in software. HW bug? At the moment in ath5k byteswapping for TX desc
is done in hardware only.
* compat wireless 2010-11-20 from openwrt was used for testing
* last two patches have to be applied together because otherwise
hardware will crash on reset if only number 9 is committed.
I have kept them separated for better visibility.
There are three false positive checkpatch warnings from them.
Changes since v5 of the patch:
* patch 8/9: add missing register accessor functions for AHB from original
patches. It was causing a crash on module unload.
* rebased on master-2010-11-23
Changes since v6 of the patch:
* these changes are based on Nick Kossifidis comments
* patch 6/9: renamed ath5k_bus_read_srev to ath5k_hw_read_srev
* patch 8/9: fixed not optimal unlikely statement in ath5k_ahb_reg
* patch 9/9: add separate function for wisoc reset and fixed wrong if
statement at the beginning of ath5k_hw_nic_wakeup
* rebased on master-2010-11-30
Felix Fietkau (9):
ath5k: Use Generic DMA for later support of AHB bus.
ath5k: Introduce ath5k_init_softc function as in ath9k
ath5k: Move PCI bus functions to separate file.
ath5k: Use generic eeprom read from common ath_bus_opts struct.
ath5k: Check if pci pdev struct is initialized in common functions.
ath5k: Add a function to read chipset's MAC revision
ath5k: Add initial registers values for radio RF2317 chip.
ath5k: Add AHB bus support.
ath5k: Fix reset and interrupts for AHB type of devices.
drivers/net/wireless/ath/ath5k/Kconfig | 17 +-
drivers/net/wireless/ath/ath5k/Makefile | 2 +
drivers/net/wireless/ath/ath5k/ahb.c | 219 ++++++++++
drivers/net/wireless/ath/ath5k/ath5k.h | 64 +++-
drivers/net/wireless/ath/ath5k/attach.c | 26 +-
drivers/net/wireless/ath/ath5k/base.c | 626 ++++++++++-------------------
drivers/net/wireless/ath/ath5k/base.h | 5 +-
drivers/net/wireless/ath/ath5k/eeprom.c | 40 +--
drivers/net/wireless/ath/ath5k/eeprom.h | 2 +-
drivers/net/wireless/ath/ath5k/initvals.c | 23 +
drivers/net/wireless/ath/ath5k/led.c | 11 +-
drivers/net/wireless/ath/ath5k/pci.c | 326 +++++++++++++++
drivers/net/wireless/ath/ath5k/reg.h | 25 ++
drivers/net/wireless/ath/ath5k/reset.c | 108 +++++-
drivers/net/wireless/ath/ath5k/sysfs.c | 4 +-
15 files changed, 1020 insertions(+), 478 deletions(-)
create mode 100644 drivers/net/wireless/ath/ath5k/ahb.c
create mode 100644 drivers/net/wireless/ath/ath5k/pci.c
next parent reply other threads:[~2010-12-02 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1193716.1141291281829918.JavaMail.wlan@CHBU500181>
2010-12-02 9:26 ` Wojciech Dubowik [this message]
2010-12-02 19:55 ` [PATCH v7 0/9] ath5k: Add AHB support John W. Linville
2010-12-04 7:02 ` Sedat Dilek
2010-12-04 7:33 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25197466.1341291282005411.JavaMail.wlan@CHBU500181 \
--to=dubowoj@neratec.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mickflemm@gmail.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).