From: Johannes Berg <johannes@sipsolutions.net>
To: Runyu Xiao <runyu.xiao@seu.edu.cn>, Jeff Johnson <jjohnson@kernel.org>
Cc: Wen Gong <quic_wgong@quicinc.com>,
Carl Huang <quic_cjhuang@quicinc.com>,
Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
P Praneesh <quic_ppranees@quicinc.com>,
Ramya Gnanasekar <quic_rgnanase@quicinc.com>,
linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 ath-current] wifi: ath12k: avoid flushing scan timeout under the wiphy lock
Date: Fri, 03 Jul 2026 09:15:42 +0200 [thread overview]
Message-ID: <251c85cf04f523e6dba6c5e02e252ed6b83a930b.camel@sipsolutions.net> (raw)
In-Reply-To: <20260703060219.2998148-1-runyu.xiao@seu.edu.cn>
On Fri, 2026-07-03 at 14:02 +0800, Runyu Xiao wrote:
>
> @@ -9975,6 +9974,15 @@ void ath12k_mac_op_stop(struct ieee80211_hw *hw, bool suspend)
>
> lockdep_assert_wiphy(hw->wiphy);
>
> + /*
> + * scan.timeout takes the wiphy lock before aborting the scan, so do
> + * not wait for it from the locked stop path below.
> + */
> + wiphy_unlock(hw->wiphy);
>
No. Don't drop locks in the middle of someone else's (mac80211 here)
process.
If that work requires wiphy mutex anyway, better just convert it to a
wiphy work.
johannes
prev parent reply other threads:[~2026-07-03 7:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 6:02 [PATCH v2 ath-current] wifi: ath12k: avoid flushing scan timeout under the wiphy lock Runyu Xiao
2026-07-03 7:15 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=251c85cf04f523e6dba6c5e02e252ed6b83a930b.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath12k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_cjhuang@quicinc.com \
--cc=quic_periyasa@quicinc.com \
--cc=quic_ppranees@quicinc.com \
--cc=quic_rgnanase@quicinc.com \
--cc=quic_wgong@quicinc.com \
--cc=runyu.xiao@seu.edu.cn \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox