From: Wen Gong <wgong@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>,
linux-wireless@vger.kernel.org, kirtika@google.com,
linux-wireless-owner@vger.kernel.org, ath11k@lists.infradead.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable
Date: Fri, 13 Nov 2020 16:51:17 +0800 [thread overview]
Message-ID: <256c487bb8c8c191a88d806e6125296e@codeaurora.org> (raw)
In-Reply-To: <0e60e4cdc036a5ef7394848d212a6e3f499c386f.camel@sipsolutions.net>
On 2020-11-13 16:35, Johannes Berg wrote:
> On Fri, 2020-11-13 at 16:35 +0800, Wen Gong wrote:
>>
>> > I guess if we really want to redefine the user rate mask to not apply
>> > to
>> > control frames, then we can relax this?
>> >
>> Yes, for AP mode, it is hard to calculate the usable rates over all
>> stations.
>> But for STATION mode, it can set 54M because AP support it, so it
>> should
>> not reject it.
>> If add a check for nl80211_iftype of ieee80211_vif in
>> ieee80211_set_bitrate_mask, it can
>> solve this like this:
>> if (sdata->vif.type != NL80211_IFTYPE_STATION &&
>> !(mask->control[band].legacy & basic_rates))
>
>
> That would forgo the check completely - we'd still need to check
> against
> the *supported* rates.
>
yes.
It can add check with supp_rates[band] of ieee80211_sta for
NL80211_IFTYPE_STATION type.
for others, check with sdata->vif.bss_conf.basic_rates
> johannes
next prev parent reply other threads:[~2020-11-13 8:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 13:20 [PATCH v2] mac80211: reject/clear user rate mask if not usable Johannes Berg
2020-11-12 10:55 ` Wen Gong
2020-11-12 12:49 ` Arend Van Spriel
2020-11-13 2:08 ` Wen Gong
2020-11-13 7:38 ` Johannes Berg
2020-11-13 8:14 ` Wen Gong
2020-11-13 8:16 ` Johannes Berg
2020-11-13 8:35 ` Wen Gong
2020-11-13 8:35 ` Johannes Berg
2020-11-13 8:51 ` Wen Gong [this message]
2020-11-13 8:51 ` Johannes Berg
2020-11-13 9:09 ` Wen Gong
2020-11-13 9:10 ` Johannes Berg
2020-11-13 9:21 ` Wen Gong
2020-11-13 9:23 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=256c487bb8c8c191a88d806e6125296e@codeaurora.org \
--to=wgong@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=kirtika@google.com \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).