From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Ben Greear <greearb@candelatech.com>
Cc: "Manoharan, Rajkumar" <rmanohar@qti.qualcomm.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: ensure pdev sta kickout threshold is set.
Date: Tue, 06 Sep 2016 22:46:38 +0530 [thread overview]
Message-ID: <258eb1b46e360aeae1cddfa9185ab1ce@codeaurora.org> (raw)
In-Reply-To: <57CEC0A4.8020808@candelatech.com>
On 2016-09-06 18:42, Ben Greear wrote:
> On 09/06/2016 12:39 AM, Manoharan, Rajkumar wrote:
>> [...]
>>
>>> +int ath10k_mac_set_pdev_kickout(struct ath10k *ar)
>>> +{
>>> + u32 param = ar->wmi.pdev_param->sta_kickout_th;
>>> + int rv;
>>> +
>>> + rv = ath10k_wmi_pdev_set_param(ar, param,
>>> +
>>> ar->sta_xretry_kickout_thresh);
>>> + if (rv) {
>>> + ath10k_warn(ar, "failed to set sta kickout threshold
>>> to %d: %d\n",
>>> + ar->sta_xretry_kickout_thresh, rv);
>>> + }
>>> + return rv;
>>> +}
>>>
>> Ben,
>>
>> I plan to get rid of setting station kickout threshold from host. Each
>> firmware revision (i.e qca988x, qca99x0, ipq4019) follows different
>> logic based on hw capability for station kickout and follows different
>> default paramters. So configuring common threshold will affect
>> firmware logic. Better to get rid of these configuration from host
>> driver and let firmware to work with default parameters.
>>
>> Also I could not find out sta_xretry_kickout_thresh definition in
>> upstream driver. Have you posted any changes for the same?
>
> Hmm, maybe that last bit is something I added in another patch.
> Probably my
> patch to enable firmware config on a per radio basis (fwcfg in my
> tree). Those patches are
> larger and probably will never make it upstream.
>
> I need a way to configure this kickout, since firmware is kicking out
> stations when it should
> not.
>
Could you please explain the scenario?
> Instead of removing the capability, you should instead make it
> configurable
> through debugfs or something like my fwcfg patches, and/or disable the
> kickout entirely.
> Since mac80211 can deal with kicking out stations already, the stuff
> in the firmware just makes
> things less stable in poor RF environments and/or with stations with
> flaky power-save and
> off-channel roaming.
>
I plan to get rid of hardcoded value and fix this through proper netlink
interface instead of debugfs. While ago, I posted a change for
configuring low ack threshold. It is still pending in my TODO list.
http://comments.gmane.org/gmane.linux.kernel.wireless.general/137645
-Rajkumar
next prev parent reply other threads:[~2016-09-06 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 19:06 [PATCH] ath10k: ensure pdev sta kickout threshold is set greearb
2016-09-06 7:39 ` Manoharan, Rajkumar
2016-09-06 13:12 ` Ben Greear
2016-09-06 17:16 ` Rajkumar Manoharan [this message]
2016-09-06 17:26 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=258eb1b46e360aeae1cddfa9185ab1ce@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).