Re: [PATCH v5] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

[Christian Lamparter <chunkeey@googlemail.com>]

On Saturday, March 11, 2017 11:04:17 PM CET Igor Mitsyanko wrote:
> This patch adds support for new FullMAC WiFi driver for Quantenna
> QSR10G chipsets.
> 
> QSR10G (aka Pearl) is Quantenna's 8x8, 160M, 11ac offering.
> QSR10G supports 2 simultaneous WMACs - one 5G and one 2G.
> 5G WMAC supports 160M, 8x8 configuration. FW supports
> up to 8 concurrent virtual interfaces on each WMAC.
> [...]
---

I see a lot of error/warning/info messages the likes of:
 
pr_err("failed to change interface type\n");
pr_err("bss not started\n");
pr_err("failed to configure phy thresholds\n");
pr_err("failed to add key\n");
pr_err("failed to delete key\n");
pr_err("failed to change STA\n");
...

I'm wondering what this will look like if there are multiple VIFs,
multiple PHYs or more than one QSR10G in a System. How - for example -
can you map a error/warning/info message to the individual Client, VIF,
PHY instance or device? From what I can tell, this is bound to get very
confusing very fast.

the kernel and cfg80211 has a ton of predefined logging and debug
functions: dev_[info|warn|err|...], wiphy_[WARN|emerg|alert|crit|err|warn|...]
I think using those functions (and adding information about the client/vif)
would tremendously help with that?

Thanks,
Christian