From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Jeff Johnson" <jjohnson@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, mhi@lists.linux.dev,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
quic_pyarlaga@quicinc.com, quic_vbadigan@quicinc.com,
quic_vpernami@quicinc.com, quic_mrana@quicinc.com
Subject: Re: [PATCH v2 09/10] PCI: Add function to convert lnkctl2speed to pci_bus_speed
Date: Thu, 13 Mar 2025 16:48:44 -0700 [thread overview]
Message-ID: <2654f986-eb8b-430d-b962-8e77d9e11826@oss.qualcomm.com> (raw)
In-Reply-To: <20250313171637.GA739165@bhelgaas>
On 3/13/2025 10:16 AM, Bjorn Helgaas wrote:
> On Thu, Mar 13, 2025 at 05:10:16PM +0530, Krishna Chaitanya Chundru wrote:
>> + * @speed: LNKCAP2 SLS value
>> + *
>> + * Returns pci_bus_speed
>
> Not sure how strict kernel-doc is about this, but I've been told
> it wants "Return:" with a colon here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/doc-guide/kernel-doc.rst?id=v6.13#n142
Yes, patchwork is flagging kernel-doc issues in this series.
However, there are numerous pre-existing kdoc issues in the MHI and PCI files
being modified in this series. Just look at the patches with errors being
flagged in patchwork (including build errors with 06/10):
https://patchwork.kernel.org/project/linux-wireless/list/?series=943497
next prev parent reply other threads:[~2025-03-13 23:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 11:40 [PATCH v2 00/10] bus: mhi: host: Add support for mhi bus bw Krishna Chaitanya Chundru
2025-03-13 11:40 ` [PATCH v2 01/10] PCI: update current bus speed as part of pci_bus_add_devices() Krishna Chaitanya Chundru
2025-03-13 17:00 ` Bjorn Helgaas
2025-04-25 15:46 ` Manivannan Sadhasivam
2025-03-13 17:00 ` Bjorn Helgaas
2025-03-13 11:40 ` [PATCH v2 02/10] PCI/bwctrl: Add support to scale bandwidth before & after link re-training Krishna Chaitanya Chundru
2025-04-25 15:57 ` Manivannan Sadhasivam
2025-05-16 12:49 ` Krishna Chaitanya Chundru
2025-03-13 11:40 ` [PATCH v2 03/10] PCI: dwc: Implement .pre_scale_bus_bw() & .post_scale_bus_bw hook Krishna Chaitanya Chundru
2025-04-25 16:02 ` Manivannan Sadhasivam
2025-03-13 11:40 ` [PATCH v2 04/10] PCI: qcom: Extract core logic from qcom_pcie_icc_opp_update() Krishna Chaitanya Chundru
2025-03-13 11:40 ` [PATCH v2 05/10] PCI: qcom: Add support for PCIe bus bw scaling Krishna Chaitanya Chundru
2025-04-25 16:07 ` Manivannan Sadhasivam
2025-03-13 11:40 ` [PATCH v2 06/10] bus: mhi: host: Add support to read MHI capabilities Krishna Chaitanya Chundru
2025-03-13 17:05 ` Bjorn Helgaas
2025-04-25 16:18 ` Manivannan Sadhasivam
2025-03-13 11:40 ` [PATCH v2 07/10] bus: mhi: host: Add support for Bandwidth scale Krishna Chaitanya Chundru
2025-04-25 16:43 ` Manivannan Sadhasivam
2025-05-06 4:29 ` Krishna Chaitanya Chundru
2025-05-17 2:20 ` Krishna Chaitanya Chundru
2025-03-13 11:40 ` [PATCH v2 08/10] PCI: Export pci_set_target_speed() Krishna Chaitanya Chundru
2025-03-13 11:40 ` [PATCH v2 09/10] PCI: Add function to convert lnkctl2speed to pci_bus_speed Krishna Chaitanya Chundru
2025-03-13 17:16 ` Bjorn Helgaas
2025-03-13 23:48 ` Jeff Johnson [this message]
2025-03-13 11:40 ` [PATCH v2 10/10] wifi: ath11k: add support for MHI bandwidth scaling Krishna Chaitanya Chundru
2025-03-13 17:28 ` Bjorn Helgaas
2025-03-18 5:23 ` Krishna Chaitanya Chundru
2025-03-13 23:53 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2654f986-eb8b-430d-b962-8e77d9e11826@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=ath11k@lists.infradead.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jingoohan1@gmail.com \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=quic_mrana@quicinc.com \
--cc=quic_pyarlaga@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=quic_vpernami@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox