From: Arnd Bergmann <arnd@arndb.de>
To: Eliad Peller <eliad@wizery.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v3 2/2] wl18xx: add basic device-tree support
Date: Sun, 08 Mar 2015 22:53:45 +0100 [thread overview]
Message-ID: <2658240.aoSloEbWge@wuerfel> (raw)
In-Reply-To: <CAB3XZEfc3qV_o+0paM=HNdySKWwiJDfH=kJ8u0tz1ae+3ujxVw@mail.gmail.com>
On Sunday 08 March 2015 13:13:13 Eliad Peller wrote:
>
> > I've looked up the what boards actually use this data and found that
> > all of them already support booting from DT: some omap2 boards using
> > arch/arm/mach-omap2/pdata-quirks.c to provide the data, and the
> > davinci 850evm. Can you make sure you add the correct data to all
> > of these dts files as part of your series and remove the
> > wl12xx_platform_data references?
>
> AFAICT, these board files add wl12xx platform data, while the new DT
> support is only for wl18xx.
>
How can you tell the difference? What I see is that omap3pandora
(and nothing else) calls wl1251_set_platform_data(), while
da850-evm and all omap3/omap4 boards use wl12xx_set_platform_data().
The latter seems to refer to all wl12xx and wl18xx variants except
for wl1251, based on my (very limited) understanding of that code.
Arnd
next prev parent reply other threads:[~2015-03-08 21:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 16:13 [PATCH v3 1/2] dt: bindings: add wl18xx wireless device Eliad Peller
2015-02-19 16:13 ` [PATCH v3 2/2] wl18xx: add basic device-tree support Eliad Peller
2015-02-27 8:26 ` Arnd Bergmann
2015-03-08 11:13 ` Eliad Peller
2015-03-08 21:53 ` Arnd Bergmann [this message]
2015-03-09 7:18 ` Eliad Peller
2015-03-09 8:50 ` Arnd Bergmann
2015-03-09 15:13 ` Eliad Peller
2015-02-27 7:35 ` [PATCH v3 1/2] dt: bindings: add wl18xx wireless device Luca Coelho
2015-02-27 8:14 ` Arnd Bergmann
2015-03-08 11:06 ` Eliad Peller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2658240.aoSloEbWge@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).