From: Pkshih <pkshih@realtek.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: "tony0620emma@gmail.com" <tony0620emma@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Bernie Huang" <phhuang@realtek.com>
Subject: RE: [PATCH] rtw88: fix c2h memory leak
Date: Thu, 24 Jun 2021 02:41:27 +0000 [thread overview]
Message-ID: <268f7949e5944eb7aeadbd6d179a3130@realtek.com> (raw)
In-Reply-To: <20210623174718.ABFCEC43460@smtp.codeaurora.org>
> -----Original Message-----
> From: kvalo=codeaurora.org@mg.codeaurora.org [mailto:kvalo=codeaurora.org@mg.codeaurora.org] On
> Behalf Of Kalle Valo
> Sent: Thursday, June 24, 2021 1:47 AM
> To: Pkshih
> Cc: tony0620emma@gmail.com; linux-wireless@vger.kernel.org; Bernie Huang
> Subject: Re: [PATCH] rtw88: fix c2h memory leak
>
> Ping-Ke Shih <pkshih@realtek.com> wrote:
>
> > From: Po-Hao Huang <phhuang@realtek.com>
> >
> > Fix erroneous code that leads to unreferenced objects. During H2C
> > operations, some functions returned without freeing the memory that only
> > the function have access to. Release these objects when they're no longer
> > needed to avoid potentially memory leaks.
> >
> > Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>
> Failed to apply, please rebase:
>
> Recorded preimage for 'drivers/net/wireless/realtek/rtw88/coex.c'
> error: Failed to merge in the changes.
> hint: Use 'git am --show-current-patch' to see the failed patch
> Applying: rtw88: fix c2h memory leak
> Using index info to reconstruct a base tree...
> M drivers/net/wireless/realtek/rtw88/coex.c
> M drivers/net/wireless/realtek/rtw88/fw.c
> M drivers/net/wireless/realtek/rtw88/main.c
> Falling back to patching base and 3-way merge...
> Auto-merging drivers/net/wireless/realtek/rtw88/main.c
> Auto-merging drivers/net/wireless/realtek/rtw88/fw.c
> Auto-merging drivers/net/wireless/realtek/rtw88/coex.c
> CONFLICT (content): Merge conflict in drivers/net/wireless/realtek/rtw88/coex.c
> Patch failed at 0001 rtw88: fix c2h memory leak
>
> Patch set to Changes Requested.
>
v2 is sent.
Thank you
--
Ping-Ke
prev parent reply other threads:[~2021-06-24 2:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 10:30 [PATCH] rtw88: fix c2h memory leak Ping-Ke Shih
2021-06-23 17:47 ` Kalle Valo
2021-06-24 2:41 ` Pkshih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=268f7949e5944eb7aeadbd6d179a3130@realtek.com \
--to=pkshih@realtek.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=phhuang@realtek.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox