From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B2AC1DC9BA for ; Tue, 18 Mar 2025 20:03:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742328214; cv=none; b=DN8AHgibPZUi7+t9UaOM/nBHNsqXpqhDpUhrbvP3es24l3S8Ogdi+xgVpR7RWqYrVRb1rApte/18g4i23ec53eWBT/sM2Qwp6CKLRTQ/2r5M+yDUod6YAsgVp57fszm9bMIAdtZroFpHJqu/fMgy3Fe0wn9Gg6G77KTURrg7/QI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742328214; c=relaxed/simple; bh=yitJU5HZqof/pX8NIh5/zha/AdJ3yoGk3GqqpscLWXU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H/x8xm17DOzKNO6EhcKamt2n4x7q6Z/kywlU2BSUUypPCP0AoXOI/zwZmzSAa9CAFRBmRQR92uxVDZUj69btiuwM+8nGHceF9AtnegdJQR7T1eqIkXvLmQiQv3KPobYA+qNm3gUWvRgFVlExE9Kowd9AH40ziNGotYB6KV1gYGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BBmVxCLU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BBmVxCLU" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52IIDHTB003310 for ; Tue, 18 Mar 2025 20:03:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dIviajEdCOBgiCD88+lBOgrVsyUY4qffh1cnELJmUSI=; b=BBmVxCLUKsP+ATsH jDgpU3DQM3izD+t3/G4Jsu+CTmR3raL/5NWe4yEdQswam7PtQ2VhOAoU35LFSjYf cq/s4FUtbuDXhSNedgAdKH8+IrquN2lueHuZ28ewYbzB8esAbP5Gt/hJVTG2Qq8B iD+ecNz4vvmNdDmIqUc7/SvNeLPmuuwZrnaNXDrEfHkgmfzUSyCzDE0nv9Bqs3+n KUmgcpbuFnimzty4c9uNmtlOkw1FtTgJQyCMbhQz26ZMhAsd/zlX7LDh3ddMQ5YT 8qp8RvVsCMdS87e5ChgSPxhAz/ZNF3sAb567OAtNeVoU/jQuiUaNSuR+Tet7iLtg 6Tx5Qg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45d1uu1cw5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 18 Mar 2025 20:03:30 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-223f3357064so89418855ad.3 for ; Tue, 18 Mar 2025 13:03:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742328209; x=1742933009; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dIviajEdCOBgiCD88+lBOgrVsyUY4qffh1cnELJmUSI=; b=nB5bGzTYpeMPfY+PPllCLqz8CKGHW28Lg1DcCkteDODr1xC/C87TrOnKhKxT7FacTf DFT+YpsFTPyc70f0gKw+TizKKTaBtf2LLqdDdC30Y8CK+QPOOVy5xZgl42kobTrnJeTU abgt9pHHvzyLnDi0WVGtP7aC2GKAAbYCtOLERdzyloiWSeZlCE7F9Pfpux/6MA3V3KpJ u5VFv+0IBYFXGwuv6LZ65tSMq49E7zPL6e6xtTPofUh32UNTcYX0QwgTl75SAdug/iw8 39S4pZzjuZizO2tSucmmUSt9BcFBdHp5GIWXnaM2KUsFRKcUkOf7NKL2n43KTYLU1xXB m0nQ== X-Forwarded-Encrypted: i=1; AJvYcCXDI363DOi4vxyXY4AoINXm1/37rOGCrh/zZLykkUuKthf7IHeIKzmMUZ9fFSQtpxDhJka7o1xtQy7333V3oQ==@vger.kernel.org X-Gm-Message-State: AOJu0YxClrwG53QMA+gd59Np3MoVoDAS+gS8GsfVNYpT7nGzEqqa6w/J 1zyMXuhu5T6Ir27txfwCYBRFskpng/bauKgVpLEnlqqJe/Czu5XSb2ijMD67jRtn+cziotLk7YC updRElee4brRRXS/lTAYgx9iTloPb+cfh24M6ZNYXbFfL4ap0RIDCsfP12eP9az8Eug== X-Gm-Gg: ASbGnct+i/AdkFf685He4mbQS5N9IXZko0kJ7TFQwIjYJz/VoL1ttTvCAyTUzx4rd6X 5csG5nju+639mIPOu/2QnhBNoBKAqhBF+lAJvy8TZAEXK8VCfebsgsYPhaZjdy9EbfZ/IgOYhSt EzFEBrSvLIOxf4KDD8ztzJ2Q0r5m6Vm2baEYHJxBM1IWm69xkTcu1IUlXMtKAJjPHTZui70IVat O8AebskjOVOkDf6/ulX/xYUmxpOKMtdCAunAw4s3EvWCnu7qkitC1lBfNiVmuTJZFX+TQBc9ung vUe/SNKz20takMEvI1OdCgmHMa5az3Mj/bXOBTS2cYT1nTVYfTTsxuOCHlUcpMFO4hpRTQg= X-Received: by 2002:a17:902:cec4:b0:215:b9a6:5cb9 with SMTP id d9443c01a7336-225e0a5212amr238093665ad.5.1742328209356; Tue, 18 Mar 2025 13:03:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwWbfqKKFOuVPqA3GS/o1rSBUsBnCbC6YlfZXuqGv4kJNVWRit7JjQXIrfwspkZnXcFQrRlg== X-Received: by 2002:a17:902:cec4:b0:215:b9a6:5cb9 with SMTP id d9443c01a7336-225e0a5212amr238093175ad.5.1742328208921; Tue, 18 Mar 2025 13:03:28 -0700 (PDT) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6bd4de5sm99117575ad.230.2025.03.18.13.03.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Mar 2025 13:03:28 -0700 (PDT) Message-ID: <26eeef33-ccae-4483-a0db-78b120ffb960@oss.qualcomm.com> Date: Tue, 18 Mar 2025 13:03:26 -0700 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next v11 08/13] wifi: ath12k: add AHB driver support for IPQ5332 To: Krzysztof Kozlowski , Raj Kumar Bhagat , ath12k@lists.infradead.org Cc: Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeff Johnson , linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Balamurugan S , P Praneesh , Vasanthakumar Thiagarajan References: <20250317204639.1864742-1-quic_rajkbhag@quicinc.com> <20250317204639.1864742-9-quic_rajkbhag@quicinc.com> <683b16dd-a3e9-4cc3-836a-95f3747d3c0a@oss.qualcomm.com> <0da16aae-2fa3-49a4-bdd3-f08a7655365f@kernel.org> <332db13c-81db-42ad-afcf-3a4262344bf2@kernel.org> <31b4ca9c-892a-4ba5-b006-95deed6deceb@kernel.org> <8e5b0ae1-ea1b-4dfa-84dc-c53edd2afc42@oss.qualcomm.com> <551018bc-26e2-47f4-8fcc-9478834b9199@kernel.org> From: Jeff Johnson Content-Language: en-US In-Reply-To: <551018bc-26e2-47f4-8fcc-9478834b9199@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=H8Pbw/Yi c=1 sm=1 tr=0 ts=67d9d192 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=VwQbUJbxAAAA:8 a=DgR1PzNg5l75-NxZnrAA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: jP3S3jpi38vDGY0ujPyZYM9R3k9UliaW X-Proofpoint-ORIG-GUID: jP3S3jpi38vDGY0ujPyZYM9R3k9UliaW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-18_09,2025-03-17_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 adultscore=0 spamscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 malwarescore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503180144 On 3/18/2025 12:06 PM, Krzysztof Kozlowski wrote: > On 18/03/2025 19:53, Jeff Johnson wrote: >> On 3/18/2025 11:19 AM, Krzysztof Kozlowski wrote: >>> On 18/03/2025 19:16, Krzysztof Kozlowski wrote: >>>> On 18/03/2025 18:55, Jeff Johnson wrote: >>>>> On 3/18/2025 8:50 AM, Krzysztof Kozlowski wrote: >>>>>> On 18/03/2025 16:44, Jeff Johnson wrote: >>>>>>> On 3/17/2025 1:46 PM, Raj Kumar Bhagat wrote: >>>>>>>> + hw_rev = (enum ath12k_hw_rev)of_device_get_match_data(&pdev->dev); >>>>>>> >>>>>>> kernel test robot warns: >>>>>>> cast to smaller integer type 'enum ath12k_hw_rev' from 'const void *' >>>>>>> >>>>>>> looks like others have fixed this by first casting to (uintptr_t) >>>>>>> a few examples: >>>>>>> >>>>>> Cast via (kernel_ulong_t) >>>>>> >>>>>> But another point is that this patch at stage v11 should not have >>>>>> compiler warnings and it's not our tools who should point it out. Except >>>>>> W=1, all standard static analyzers (sparse, smatch and coccinelle) are >>>>>> expected to be run. >>>>> >>>>> I ran what I thought was a reasonable cross-section of builds and did not see >>>>> this issue. Seems this issue is only flagged with config: um-allmodconfig ?? >>>>> >>>>> Guess I need to add that configuration to my builds... >>>> >>>> This should be visible on every build on 32 bit archs. >> >> Yes, I'm seeing it now on my i386 builds >> >>> Patchset does not apply neither on next nor on on mainline, so cannot >>> verify... Probably another problem to solve here - some sort of dependency? >> >> T: git git://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git >> >> The series should apply cleanly on ath.git ath-next branch > > > Yeah, but next is fed with for-next branch, not ath-next.... and > for-next is 10 days behind ath-next. I assume for-next is what you send > to the next merge window and ath-next is rather next-next-merge window, > just like DRM people are doing? we have for-next which feeds linux-next. normally for-next is a symbolic ref to ath-next. but when we issue our last PR to wireless-next before the merge window, after we are pulled we fast-forward and hard branch for-next. so from that point our contributions to linux-next stop while we continue to contribute to ath-next. when the merge window closes we remove the hard branch and reestablish the symbolic ref. /jeff