From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B12FC433EF for ; Wed, 15 Sep 2021 18:48:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39D3860EE2 for ; Wed, 15 Sep 2021 18:48:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230362AbhIOSuJ (ORCPT ); Wed, 15 Sep 2021 14:50:09 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:33639 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231664AbhIOStT (ORCPT ); Wed, 15 Sep 2021 14:49:19 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1631731680; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=f2Eq/1pPqgCPndJdn/eUy4HOGPYck/3mHt4Y/gsvJHw=; b=ncX+qL3Uv7DbRwNVEuAWqQEgjjHuhKFg1u3mhV8OzGzPjMJjKwBdoqE9kSRChdVhVCyXiyrz /OFIrNIK9KrvX7EksstOsqQwpmAZH0C7UJjUBqIJ5gcioRqtw8lyff2rc37Q006qvF6NUbUn jY6EPsaYj2J89oBkhm5IrvEH7ng= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 61423fc6ec62f57c9a2f48e1 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 15 Sep 2021 18:47:34 GMT Sender: alokad=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BC4B1C43460; Wed, 15 Sep 2021 18:47:33 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: alokad) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7DF29C4338F; Wed, 15 Sep 2021 18:47:33 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 15 Sep 2021 11:47:03 -0700 From: Aloka Dixit To: Johannes Berg Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH v11 0/4] multiple bssid and EMA support in AP mode In-Reply-To: <4c5314e8d15565759fec3edf0729e8d4f2e28319.camel@sipsolutions.net> References: <20210715070745.5033-1-alokad@codeaurora.org> <849e2cf64fbf774fec9c30003e828aaf2d12a6d7.camel@sipsolutions.net> <8263a758863ac8fcd2d4ae6b36668bc8@codeaurora.org> <4c5314e8d15565759fec3edf0729e8d4f2e28319.camel@sipsolutions.net> Message-ID: <27559beca2f618ec1e535214d1d0a004@codeaurora.org> X-Sender: alokad@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-09-15 03:47, Johannes Berg wrote: > On Tue, 2021-09-14 at 20:47 -0700, Aloka Dixit wrote: >> On 2021-08-17 03:35, Johannes Berg wrote: >> > On Thu, 2021-07-15 at 00:07 -0700, Aloka Dixit wrote: >> > > This patchset adds support for multiple BSSID and >> > > enhanced multi-BSSID advertisements for AP mode. >> > > Individual patches describe the changes in this version. >> > >> > How about adding the trivial advertisement to hwsim so we can have some >> > tests in hostapd? >> > >> > johannes >> >> Hi Johannes, >> Yes, I plan to add hwsim advertisement separately once kernel >> changes are accepted. Will also add hostapd testcases at the >> same time. > > OK, great! But adding it in hwsim is a kernel change, so why not just > send that patch together? > > johannes Hi Johannes, Trivial advertisement will not work because mac80211_hwsim_beacon_tx() does not handle the EMA case which may have more than one beacons transmitted. It will need to be changed to use the newly added ieee80211_beacon_get_template(). Hence I will add a separate change for HWSIM. Thanks.