From: Christian Lamparter <chunkeey@gmail.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: "Frank Schäfer" <fschaefer.oss@googlemail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] carl9170: remove P2P_GO support
Date: Tue, 05 May 2020 20:31:01 +0200 [thread overview]
Message-ID: <27876964.GhbJDmQBxd@debian64> (raw)
In-Reply-To: <87368ej1aj.fsf@tynnyri.adurom.net>
Hello,
On Tuesday, 5 May 2020 09:20:20 CEST Kalle Valo wrote:
> Frank Schäfer <fschaefer.oss@googlemail.com> writes:
> >
> > Am 25.04.20 um 11:28 schrieb Christian Lamparter:
> >> This patch follows up on a bug-report by Frank Schäfer that
> >> discovered P2P GO wasn't working with wpa_supplicant.
> >> This patch removes part of the broken P2P GO support but
> >> keeps the vif switchover code in place.
> >
> > Hmm... no way to fix it ?
> > P2P-GO seems to work fine with p2p_no_group_iface=1, so do you really
> > think it's a good idea / required to remove the whole thing ?
> >
> >> Cc: <stable@vger.kernel.org>
> >
> > Are you sure about that ?
> > People might be using it...
>
> Christian, what should I do? Take the patch or drop it?
Well, the way I see it: AR9170's silicon die has been cast before
P2P was a thing. And while it was nice back in '10 then to had have
something to test ath9k with, by todays standards the lack of features
like separate TSF sync and the cacheless BA makes it so that it's holding
back the performance and connection quality of all the clients which are
connected to it.
So, I think we'll just kicking down the can on that and I'm sorry that
I gave the people the wrong impression. There are much better chips now
that came with P2P in mind.
So: please take the patch.
Cheers
Christian
next prev parent reply other threads:[~2020-05-05 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 9:28 [PATCH] carl9170: remove P2P_GO support Christian Lamparter
2020-04-26 10:33 ` Frank Schäfer
2020-05-05 7:20 ` Kalle Valo
2020-05-05 18:31 ` Christian Lamparter [this message]
2020-05-06 6:04 ` Kalle Valo
2020-05-06 6:15 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27876964.GhbJDmQBxd@debian64 \
--to=chunkeey@gmail.com \
--cc=fschaefer.oss@googlemail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).