From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.31 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794767194; b=k1OIr5iENSFTUOxXaShlGR6t1Yn4VeaNmm+5wwmN/IA4tdPJkhWYBDfn3E8w8PBuCasF 2ZoEoEJlRBOYi9VtpCUSuRDY2LBLN5IkZzKibREJufu5BcdGbYRSRJZmV39LO2POilKcK K1UyVbxzXRvc7hAhnV6CFhNC9C0r1/Mp+j094/K/zIrzjkowZlahqpceiVtgzWO7GcZUq kTyg9PtVweK/dR0eQQrMiQ0TyZ+XJoFldn9hBfAu08KFEznbKz2gIZ2QG34OkwRSNSefu wGjrryaasl8HkyYEEv9dQ6HBHFykEjcvVO9ZlvWqPBYWihPHEBQjvrMqdwInoooAYQA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794767194; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:CC:Subject:In-Reply-To: References:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding; bh=6hhvBoZDMPREBK+QllaLdak4HEXlDgN9M+ym2CatEzY=; b=BT5ieYoOjtYYJTGJ+Ti0VLJRiSH3YJPZBI4ZI7HHigmOjc0rLZH1br4ORK0obBXKbjOP 6n11DZ70ADJaB+T1UpzeXBYqiBX/i2l6qc1jKxEDoeea5hWucAVvUhj8gFfRZqJe22Y82 W3JK1R7ooX/KWH1XO9jrPddiW8yifpjqlP/hvOfXVMCPP4yzhvFFgvwbm+22kLaVFQ6Yg OU3wYQAVcklepOF2k2+9++bnR0X0xakTncJfE1BYOjC5f6F03CLeAKeG4RNA/fKgRdzx4 1Y/cbjTmL8QkOi2PROyjsKW4DpPfhLj88Wl+v6bKMqqU+S9c9bOvEhO7AuAK0fd1f8w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=xWqq6Ytz; arc=none smtp.remote-ip=91.218.175.31 Received: from mta0.migadu.com (out-31.mta0.migadu.com [91.218.175.31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10B0B606A330 for ; Sun, 15 Nov 2026 18:26:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 10B0B606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=xWqq6Ytz X-Envelope-To: linux-wireless@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=ya6B7gVo7+tq2SFNtrJ1DU++OTmw3FzfOanRib/ggkk=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794767190; v=1; x=1795371990; b=xWqq6Ytz+wVRlDOrMYXwYvevrkjMQ2eN1dUy6pZtXSnaZwi1oN2q7riacxrRWNYLVN9E0Ehv LYZUz6bsXFqz3tNvFFgx659Ciizs7knUMWW4XHi42RLNgHAoqRrbk2p9il0MFPhlZAzmkhgFbVd hI0DjERIL3eV02eMIHU2N/9I= X-Envelope-To: linux-wireless@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 0dbe625ad8b95c5b; Sun, 15 Nov 2026 18:26:30 +0000 X-Mizu-Trace-ID: 0dbe625ad8b95c5b X-Migadu-Flow: FLOW_OUT Date: Sun, 15 Nov 2026 19:26:25 +0100 From: Luka Gejak To: linux-wireless@vger.kernel.org, Leonard Lausen , Ping-Ke Shih CC: leonard@lausen.nl, Shawn Lin , Heiko Stuebner , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] wifi: rtw88: reduce RTL8822CS SDIO request overhead In-Reply-To: <20261115142330.359247-2-leonard@lausen.nl> References: <20261115142330.359247-2-leonard@lausen.nl> Message-ID: <27B2AC6E-6293-4287-B966-986AF8C0CABE@linux.dev> X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hi Leonard, On November 15, 2026 3:23:28 PM GMT+01:00, Leonard Lausen wrote: >Reduce SDIO request overhead by filtering hardware-handled control >frames and combining adjacent TX-capacity reads. > >RTL8822CS on NanoPi M5, median TCP Mbit/s: > > Upload Download > Neither patch 170.4 241.2 > Filtering only 258.2 263.3 > Combined register reads only 186.5 261.6 > Both patches 286.9 273.5 > >Together the patches improved median upload by 68% and download by 13.4%. >Upload and download were measured in separate sessions, with four >20-second upload samples and four 30-second download samples per >configuration. Testing used a shared Wi-Fi network, so throughput can >vary. > >Runtime baseline: v7.4-rc2 plus the RX-bounds fix accepted in rtw-next >(83ca360e85280) and the MMC voltage-switch fixes in linux-next Series targeted for rtw-next should be based on rtw-next, unless there is a good reason for doing otherwise. >(67a97316a31a3, a3838c21e28e5). All variants use stock MMC host limits, >198 MHz SDR104, performance governors and identical CPU placement: >SDIO IRQ on CPU4, iperf client on CPU6, server on CPU7. Traffic crosses >Wi-Fi/AP/Ethernet between two endpoints on the board. > >All 20 configured rtw88 modules built with W=1. Sanitized function models >cover credit-read errors, fallback and buffer ownership. Module IDs, >filter registers, traffic paths and kernel logs were checked. AP/monitor, >suspend/resume and other-chip hardware remain untested. > >AI assistance: Codex inspected sources, developed the changes and >messages, >and automated validation. Prompts requested small optimizations measured >individually and together, with explicit prerequisite and impact checks. > >Leonard Lausen (2): > wifi: rtw88: 8822c: filter hardware-handled control frames on SDIO > wifi: rtw88: sdio: combine free TX page register reads > > drivers/net/wireless/realtek/rtw88/reg.h | 4 ++ > drivers/net/wireless/realtek/rtw88/rtw8822c.c | 9 +++ > drivers/net/wireless/realtek/rtw88/sdio.c | 58 +++++++++++++++++-- > drivers/net/wireless/realtek/rtw88/sdio.h | 1 + > 4 files changed, 68 insertions(+), 4 deletions(-) > >base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb Can you resend this properly, as v2, as resending singular patches is not encouraged? For the actual patches: Read Documentation/process/coding-style.rst and apply what you learn in there to all patches. Furthermore Assisted-by tag is deprecated and should be removed, which you would have seen if you had ran checkpatch on your patches. Address these and other style issues and I will review v2, as I don't have time right now. Best regards, Luka Gejak