RE: [PATCH rtw-next] wifi: rtw88: validate RX rate to prevent out-of-bound

[Ping-Ke Shih <pkshih@realtek.com>]

LB F <goainwo@gmail.com> wrote:
> Ping-Ke Shih <pkshih@realtek.com> wrote:
> > The reported RX rate might be unexpected, causing kernel warns:
> >   Rate marked as a VHT rate but data is invalid: MCS: 0, NSS: 0
> >   WARNING: net/mac80211/rx.c:5491 at ieee80211_rx_list+0x183/0x1020
> [mac80211]
> > As the RX rate can be index of an array under certain conditions, validate
> > it to prevent accessing array out-of-bound potentially.
> 
> Tested on HP Notebook P3S95EA#ACB (kernel 6.19.9-1-cachyos):
> 
>   - No WARNING: net/mac80211/rx.c:5491 observed after patch.
>   - System remains fully stable through idle, load, Bluetooth A2DP
>     usage, and multiple suspend/resume cycles.
>   - Zero h2c or lps errors in dmesg.
> 
> Tested-by: Oleksandr Havrylov <goainwo@gmail.com>

Thanks for your test. As the change in data path, I'd add an unlikely()
by v2. Also, take your test info. If v2 doesn't work to you (I think
the result of v2 must be identical to v1), please NACK me by v2 patch
I will send out right away.

Ping-Ke