Linux wireless drivers development
 help / color / mirror / Atom feed
From: Wojciech Dubowik <dubowoj@neratec.com>
To: linux-wireless <linux-wireless@vger.kernel.org>
Cc: lrodriguez <lrodriguez@atheros.com>, nbd <nbd@openwrt.org>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: [RFC] mac80211: Allow AP to change channels for DFS support
Date: Tue, 11 Jan 2011 14:34:41 +0100 (CET)	[thread overview]
Message-ID: <2847292.30.1294752879394.JavaMail.wlan@CHBU500181> (raw)
In-Reply-To: <5380482.20.1294752135253.JavaMail.wlan@CHBU500181>

Hello,

  I have started studying DFS support possibilities in ath9k 
and I have noticed that at the moment AP is not allowed to 
change channels when it's using beacons.

I have found that I can go around it by setting CHAN_MODE_UNDEFINED
for this case. Not sure whether we need extra mode for it but
to me this is a case when AP is neither fixed nor hopping.

--- a/net/mac80211/chan.c
+++ b/net/mac80211/chan.c 
@@ -34,8 +34,11 @@
 				return CHAN_MODE_HOPPING;
 		}
 
-		if (sdata->vif.type == NL80211_IFTYPE_AP &&
-		    !sdata->u.ap.beacon)
+
+		/* TODO: CHAN_MODE_FIXED shouldn't be set when
+		  AP is on DFS channel. For now assume always
+		  undefined */
+		if (sdata->vif.type == NL80211_IFTYPE_AP)
 			continue;
 
 		return CHAN_MODE_FIXED;


It's also possible to check whether channel is of radar type
and set mode undefined for this case. Question is whether it's 
needed at all.

Any comments?

Br,
Wojtek

       reply	other threads:[~2011-01-11 13:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5380482.20.1294752135253.JavaMail.wlan@CHBU500181>
2011-01-11 13:34 ` Wojciech Dubowik [this message]
2011-01-11 13:43   ` [RFC] mac80211: Allow AP to change channels for DFS support Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2847292.30.1294752879394.JavaMail.wlan@CHBU500181 \
    --to=dubowoj@neratec.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lrodriguez@atheros.com \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox