Linux wireless drivers development
 help / color / mirror / Atom feed
From: Alexander Simon <an.alexsimon@googlemail.com>
To: Marek Lindner <lindner_marek@yahoo.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/4] nl80211: Parse channel type attribute in an IBSS join request
Date: Wed, 31 Aug 2011 18:44:47 +0200	[thread overview]
Message-ID: <2853752.GZVY6pETLZ@alex-1> (raw)
In-Reply-To: <201108311751.20806.lindner_marek@yahoo.de>

Am Mittwoch, 31. August 2011, 17:51:20 schrieben Sie:
> On Monday, August 29, 2011 16:15:47 Alexander Simon wrote:
> >         if (!ibss.channel ||
> > 
> > +           ibss.channel->flags & IEEE80211_CHAN_PASSIVE_SCAN ||
> > 
> >             ibss.channel->flags & IEEE80211_CHAN_NO_IBSS ||
> > 
> > -           ibss.channel->flags & IEEE80211_CHAN_DISABLED)
> > +           ibss.channel->flags & IEEE80211_CHAN_RADAR)
> > +               return -EINVAL;
> 
> Do you mind elaborating why this patch removes the IEEE80211_CHAN_DISABLED
> check and adds the IEEE80211_CHAN_RADAR check instead ? Copy and paste error
> ?
You're right.

I've adopted this from the check in cfg80211_can_use_ext_chan in 
net/wireless/chan.c and probably missed the DISABLED check.

Thanks.
Will be fixed in v3.

Alex

      reply	other threads:[~2011-08-31 16:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29 14:15 [PATCH v2 1/4] nl80211: Parse channel type attribute in an IBSS join request Alexander Simon
2011-08-29 14:30 ` [PATCH v2 2/4] cfg80211: Add cfg80211_get_bss_ht to also match HT configuration Alexander Simon
2011-08-31  6:37   ` Johannes Berg
2011-09-09 14:07   ` Marek Lindner
2011-08-29 14:31 ` [PATCH v2 3/4] mac80211: Add HT helper functions Alexander Simon
2011-08-31  6:38   ` Johannes Berg
2011-08-29 14:32 ` [PATCH v2 4/4] mac80211: Add HT operation modes for IBSS Alexander Simon
2011-09-09 14:17   ` Marek Lindner
2011-08-31  6:36 ` [PATCH v2 1/4] nl80211: Parse channel type attribute in an IBSS join request Johannes Berg
2011-08-31 13:49   ` Alexander Simon
2011-09-01 13:18     ` Johannes Berg
2011-08-31 15:51 ` Marek Lindner
2011-08-31 16:44   ` Alexander Simon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2853752.GZVY6pETLZ@alex-1 \
    --to=an.alexsimon@googlemail.com \
    --cc=lindner_marek@yahoo.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox