linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Lamparter <chunkeey@googlemail.com>
To: Mohammed Shafi Shajakhan <mohammed@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	Kalle Valo <kvalo@qca.qualcomm.com>
Subject: Re: [PATCH 1/2] ath10k: add accounting for the extended peer statistics
Date: Thu, 15 Dec 2016 18:24:13 +0100	[thread overview]
Message-ID: <2970240.ih558OrmaK@debian64> (raw)
In-Reply-To: <20161215164338.GB8030@atheros-ThinkPad-T61>

Hello Shafi,

On Thursday, December 15, 2016 10:13:39 PM CET Mohammed Shafi Shajakhan wrote:
> I am also thinking, as of now there is not much use in appending
> the extended peer stats (which gets periodically ) to the linked list
> '&ar->debug.fw_stats.peers_extd)'  and should we get rid of the below
> (and the required cleanup as well) 
> 
> list_splice_tail_init(&stats.peers_extd,
> 		&ar->debug.fw_stats.peers_extd);
> 
> 
> since rx_duration is getting updated periodically to the per sta
> information. Kindly let me know your thoughts about this.

Yes, of course. I see what your are trying to do and I think it's much better
to get rid of peers_extd and ath10k_fw_extd_stats_peers_free.

Regards,
Christian

  reply	other threads:[~2016-12-15 17:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-05 21:52 [PATCH 1/2] ath10k: add accounting for the extended peer statistics Christian Lamparter
2016-12-05 21:52 ` [PATCH 2/2] ath10k: fix potential memory leak in ath10k_wmi_tlv_op_pull_fw_stats() Christian Lamparter
2016-12-30  9:11   ` [2/2] " Kalle Valo
2016-12-07  6:28 ` [PATCH 1/2] ath10k: add accounting for the extended peer statistics Mohammed Shafi Shajakhan
2016-12-13 12:41   ` Christian Lamparter
2016-12-14  7:33     ` Mohammed Shafi Shajakhan
2016-12-14 16:38       ` Christian Lamparter
2016-12-15 16:26         ` Mohammed Shafi Shajakhan
2016-12-15 16:43           ` Mohammed Shafi Shajakhan
2016-12-15 17:24             ` Christian Lamparter [this message]
2016-12-16  5:24               ` Mohammed Shafi Shajakhan
2016-12-17 17:46                 ` [PATCH] ath10k: merge extended peer info data with existing peers info Christian Lamparter
2016-12-19 16:49                   ` Mohammed Shafi Shajakhan
2016-12-19 16:58                     ` Mohammed Shafi Shajakhan
2016-12-19 18:37                     ` Christian Lamparter
2016-12-22 15:48                       ` Mohammed Shafi Shajakhan
2016-12-22 17:58                         ` Christian Lamparter
2016-12-29 14:35                           ` Mohammed Shafi Shajakhan
2017-05-05 12:51                   ` Kalle Valo
2016-12-29 14:11 ` [1/2] ath10k: add accounting for the extended peer statistics Kalle Valo
2016-12-30 14:35   ` Christian Lamparter
2016-12-30 14:47     ` Valo, Kalle
2017-01-03  5:28     ` Mohammed Shafi Shajakhan
2017-01-04 20:06       ` Christian Lamparter
2017-01-11 10:49         ` Valo, Kalle
2017-01-13 13:28 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2970240.ih558OrmaK@debian64 \
    --to=chunkeey@googlemail.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mohammed@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).