Re: [PATCH v1] PCI: Add PCI_DEVICE_DATA() macro to fully describe device ID entry

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Fri, 2018-07-27 at 13:42 -0700, Randy Dunlap wrote:
> On 07/27/2018 01:41 PM, Andy Shevchenko wrote:
> > On Fri, 2018-07-27 at 23:39 +0300, Andy Shevchenko wrote:
> > > There are a lot of examples in the kernel where PCI_VDEVICE() is
> > > used
> > > and still
> > > looks not so convenient due to additional driver_data field
> > > attached.
> > > 
> > > Introduce PCI_DEVICE_DATA() macro to fully describe device ID
> > > entry in
> > > shortest
> > > possible form. For example,
> > > 
> > >   before:
> > > 
> > >     { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_MRFLD),
> > >       (kernel_ulong_t) &dwc3_pci_mrfld_properties, },
> > > 
> > >   after:
> > > 
> > >     { PCI_VDEVICE(INTEL, INTEL_MRFLD, &dwc3_pci_mrfld_properties
> > > },
> > > 
> > > Drivers can be converted later on in independent way.
> > > 
> > > While here, remove the unused macro with the same name
> > > from Ralink wireless driver.
> > 
> > Skip this, it missed one comma.
> 
> s/comma/right paren/ ??

comma in the code and you are right about commit message. Btw, it missed
rename as well there.

Thanks for spotting this!

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy